Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-08-14 Thread Noboru Saito
> > Building on the first patch, the second patch adjusts the column widths of > > various tables in the documentation to take advantage of the increased > > display width. > > I have committed this, except the change in table > functions-pg-control-recovery, which didn't seem right. Thank you for

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-08-13 Thread Peter Eisentraut
On 08.05.25 09:18, Noboru Saito wrote: 3. **Replaced `text-indent` with `margin-left` for `func_signature` and `column_definition`**: - The previous `text-indent: -3.5em` only affected the first line, causing inconsistent formatting for multi-line code blocks. Changing this to `margin-left: 0em`

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-08-13 Thread Peter Eisentraut
On 08.05.25 09:18, Noboru Saito wrote: ### Patch 2: Adjustments to table column widths Building on the first patch, the second patch adjusts the column widths of various tables in the documentation to take advantage of the increased display width. I have committed this, except the change in ta

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-08-13 Thread Peter Eisentraut
On 26.06.25 08:47, Tatsuo Ishii wrote: Dear Kuroda-san, Dear Ishii-san, Actually Saito-san has already been registered [1]. And cfbot said OK. [1]: https://commitfest.postgresql.org/patch/5775/ Thank you for pointing it out. Also I see Peter has been already registered as a committer. Great

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-25 Thread Tatsuo Ishii
Dear Kuroda-san, > Dear Ishii-san, > > Actually Saito-san has already been registered [1]. And cfbot said OK. > > [1]: https://commitfest.postgresql.org/patch/5775/ Thank you for pointing it out. Also I see Peter has been already registered as a committer. Great. Best regards, -- Tatsuo Ishii

RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-25 Thread Hayato Kuroda (Fujitsu)
Dear Ishii-san, Actually Saito-san has already been registered [1]. And cfbot said OK. [1]: https://commitfest.postgresql.org/patch/5775/ Best regards, Hayato Kuroda FUJITSU LIMITED

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-25 Thread Tatsuo Ishii
Dear Saito-san, >> Dear Ishii-san, >> >>> I wonder how your patches apply to non A4 format (letter). Can you >>> please share the PDF file in letter format after patching? >> >> I had not mentioned the US letter format before, but the patch also >> affects the US letter version. >> I attach a P

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-12 Thread Tatsuo Ishii
Dear Saito-san, > Dear Ishii-san, > >> I wonder how your patches apply to non A4 format (letter). Can you >> please share the PDF file in letter format after patching? > > I had not mentioned the US letter format before, but the patch also > affects the US letter version. > I attach a PDF of th

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-11 Thread Tatsuo Ishii
> Dear Kuroda-san, > > 2025年6月11日(水) 13:48 Hayato Kuroda (Fujitsu) : >> > I have also attached a part of the PDF generated with both 0001 and >> > 0002 applied for your reference. >> >> The patch is cleanly created, and +1 for all contents. > > Thank you very much for your review and for confirmi

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-11 Thread Noboru Saito
Dear Kuroda-san, 2025年6月11日(水) 13:48 Hayato Kuroda (Fujitsu) : > > I have also attached a part of the PDF generated with both 0001 and > > 0002 applied for your reference. > > The patch is cleanly created, and +1 for all contents. Thank you very much for your review and for confirming the patch c

RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-10 Thread Hayato Kuroda (Fujitsu)
Dear Saito-san, > Yes, your understanding is correct. The top-right image was generated > with the previous patch, and the bottom-right with the v2 patch. > > Thank you also for your advice regarding splitting the patch into two parts: > - 0001: Set both body.start.indent and body.end.indent to 0

RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-09 Thread Hayato Kuroda (Fujitsu)
Dear Saito-san, > - A patch that adds margins to admonition blocks. > - An updated image where I have highlighted the space with a red > border for clarity. > > The image shows: > - The original layout (top left) > - Only indentation set to 0 (top right) > - Indentation 0 plus admonition margins

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-05 Thread Peter Eisentraut
On 30.05.25 01:06, Noboru Saito wrote: I suggest setting both body.start.indent and body.end.indent to 0 in stylesheet-fo.xsl as follows: 0 0 This change maximizes the usable width of each page in the generated PDF documentation. As a result, the total number of pages is reduced from 3095 to 29

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-06-01 Thread Florents Tselai
> On 30 May 2025, at 8:27 AM, Noboru Saito wrote: > > Thank you Kuroda-san. > >> To confirm, generated pdf with current setting is left slide, and it would >> become like right side, is it correct? I prefer right one. > > Sorry for the lack of explanation. > That's right, the version on the

Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-05-29 Thread Noboru Saito
Thank you Kuroda-san. > To confirm, generated pdf with current setting is left slide, and it would > become like right side, is it correct? I prefer right one. Sorry for the lack of explanation. That's right, the version on the left is the previous version, and the version on the right has the pa

RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

2025-05-29 Thread Hayato Kuroda (Fujitsu)
Dear Saito-san, > Since my previous email included many changes and may have been > difficult to review, I would like to propose a much simpler change > this time. I feel this is a reasonable approach. If needed, you can create set of patches and can discuss from 0001. See [1]. > I suggest setti