Re: [PATCH] Redudant initilization

2020-09-05 Thread Ranier Vilela
Em sáb., 5 de set. de 2020 às 14:29, Tom Lane escreveu: > Ranier Vilela writes: > > Attached is a patch I made in March/2020, but due to problems, > > it was sent but did not make the list. > > Would you mind taking a look? > > I applied some of this, but other parts had been overtaken by >

Re: [PATCH] Redudant initilization

2020-09-05 Thread Tom Lane
Ranier Vilela writes: > Attached is a patch I made in March/2020, but due to problems, > it was sent but did not make the list. > Would you mind taking a look? I applied some of this, but other parts had been overtaken by events, and there were other changes that I didn't agree with. A general

Re: [PATCH] Redudant initilization

2020-09-05 Thread Ranier Vilela
Em sex., 4 de set. de 2020 às 18:20, Ranier Vilela escreveu: > Em sex., 4 de set. de 2020 às 14:40, Tom Lane > escreveu: > >> Bruce Momjian writes: >> > I have to say, I am kind of stumped why compilers do not warn of such >> > cases, and why we haven't gotten reports about these cases before.

Re: [PATCH] Redudant initilization

2020-09-04 Thread Ranier Vilela
Em sex., 4 de set. de 2020 às 14:40, Tom Lane escreveu: > Bruce Momjian writes: > > I have to say, I am kind of stumped why compilers do not warn of such > > cases, and why we haven't gotten reports about these cases before. > > I was just experimenting with clang's "scan-build" tool. It finds

Re: [PATCH] Redudant initilization

2020-09-04 Thread Tom Lane
Bruce Momjian writes: > I have to say, I am kind of stumped why compilers do not warn of such > cases, and why we haven't gotten reports about these cases before. I was just experimenting with clang's "scan-build" tool. It finds all of the cases you just fixed, and several dozen more beside.

Re: [PATCH] Redudant initilization

2020-09-04 Thread Ranier Vilela
Em sex., 4 de set. de 2020 às 11:01, Bruce Momjian escreveu: > On Fri, Sep 4, 2020 at 09:39:45AM -0300, Ranier Vilela wrote: > > Em qui., 3 de set. de 2020 às 23:57, Bruce Momjian > escreveu: > > > > On Wed, Apr 1, 2020 at 08:57:18AM -0300, Ranier Vilela wrote: > > > Hi, > > > New

Re: [PATCH] Redudant initilization

2020-09-04 Thread Bruce Momjian
On Fri, Sep 4, 2020 at 09:39:45AM -0300, Ranier Vilela wrote: > Em qui., 3 de set. de 2020 às 23:57, Bruce Momjian > escreveu: > > On Wed, Apr  1, 2020 at 08:57:18AM -0300, Ranier Vilela wrote: > > Hi, > > New patch with yours suggestions. > > Patch applied to head, thanks. >

Re: [PATCH] Redudant initilization

2020-09-04 Thread Ranier Vilela
Em qui., 3 de set. de 2020 às 23:57, Bruce Momjian escreveu: > On Wed, Apr 1, 2020 at 08:57:18AM -0300, Ranier Vilela wrote: > > Hi, > > New patch with yours suggestions. > > Patch applied to head, thanks. > Thank you Bruce. regards, Ranier Vilela

Re: [PATCH] Redudant initilization

2020-09-03 Thread Bruce Momjian
On Wed, Apr 1, 2020 at 08:57:18AM -0300, Ranier Vilela wrote: > Hi, > New patch with yours suggestions. Patch applied to head, thanks. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its

Re: [PATCH] Redudant initilization

2020-04-01 Thread Ranier Vilela
Hi, New patch with yours suggestions. best regards, Ranier Vilela v2_redundant_initialization.patch Description: Binary data

Re: [PATCH] Redudant initilization

2020-03-30 Thread Ranier Vilela
Em dom., 29 de mar. de 2020 às 21:57, Kyotaro Horiguchi < horikyota@gmail.com> escreveu: > Hello. > > At Sat, 28 Mar 2020 19:04:00 -0300, Ranier Vilela > wrote in > > Hi, > > This patch fixes some redundant initilization, that are safe to remove. > > > diff --git

Re: [PATCH] Redudant initilization

2020-03-29 Thread Kyotaro Horiguchi
Hello. At Sat, 28 Mar 2020 19:04:00 -0300, Ranier Vilela wrote in > Hi, > This patch fixes some redundant initilization, that are safe to remove. > diff --git a/src/backend/access/gist/gistxlog.c > b/src/backend/access/gist/gistxlog.c > index d3f3a7b803..ffaa2b1ab4 100644 > ---

[PATCH] Redudant initilization

2020-03-28 Thread Ranier Vilela
Hi, This patch fixes some redundant initilization, that are safe to remove. best regards, Ranier Vilela redudant_initialization.patch Description: Binary data