Re: [PATCH] Remove useless distinct clauses

2020-09-30 Thread Michael Paquier
On Tue, Sep 15, 2020 at 10:57:04PM +1200, David Rowley wrote: > Unfortunately, there are quite a few issues with what you have: This review has not been answered after two weeks, so this is marked as RwF. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Remove useless distinct clauses

2020-09-19 Thread Bruce Momjian
On Tue, Sep 15, 2020 at 10:57:04PM +1200, David Rowley wrote: > On Fri, 31 Jul 2020 at 20:41, Pierre Ducroquet wrote: > > > > In a recent audit, I noticed that application developers have a tendency to > > abuse the distinct clause. For instance they use an ORM and add a distinct > > at > > the

Re: [PATCH] Remove useless distinct clauses

2020-09-15 Thread David Rowley
On Fri, 31 Jul 2020 at 20:41, Pierre Ducroquet wrote: > > In a recent audit, I noticed that application developers have a tendency to > abuse the distinct clause. For instance they use an ORM and add a distinct at > the top level just because they don't know the cost it has, or they don't know >

Re: [PATCH] Remove useless distinct clauses

2020-07-31 Thread Ashutosh Bapat
Hi Pierre, On Fri, Jul 31, 2020 at 2:11 PM Pierre Ducroquet wrote: > > Hi > > In a recent audit, I noticed that application developers have a tendency to > abuse the distinct clause. For instance they use an ORM and add a distinct at > the top level just because they don't know the cost it has,

[PATCH] Remove useless distinct clauses

2020-07-31 Thread Pierre Ducroquet
Hi In a recent audit, I noticed that application developers have a tendency to abuse the distinct clause. For instance they use an ORM and add a distinct at the top level just because they don't know the cost it has, or they don't know that using EXISTS is a better way to express their queries