Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-08 Thread Yura Sokolov
В Сб, 09/07/2022 в 02:32 +0300, Yura Sokolov пишет: > В Пт, 08/07/2022 в 11:04 -0400, Robert Haas пишет: > > On Fri, Jul 8, 2022 at 10:11 AM Yura Sokolov > > wrote: > > > I see analogy with Bus Stop: > > > - there is bus stop > > > - there is a schedule of bus arriving this top > > > - there are

Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-08 Thread Yura Sokolov
В Пт, 08/07/2022 в 11:04 -0400, Robert Haas пишет: > On Fri, Jul 8, 2022 at 10:11 AM Yura Sokolov wrote: > > I see analogy with Bus Stop: > > - there is bus stop > > - there is a schedule of bus arriving this top > > - there are passengers, who every day travel with this bus > > > > Bus

Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-08 Thread Robert Haas
On Fri, Jul 8, 2022 at 10:11 AM Yura Sokolov wrote: > I see analogy with Bus Stop: > - there is bus stop > - there is a schedule of bus arriving this top > - there are passengers, who every day travel with this bus > > Bus occasionally comes later... Well, it comes later quite often... > > Which

Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-08 Thread Yura Sokolov
В Пт, 08/07/2022 в 09:44 -0400, Robert Haas пишет: > On Thu, Jul 7, 2022 at 10:39 PM Kyotaro Horiguchi > wrote: > > At Thu, 7 Jul 2022 13:58:06 -0500, Justin Pryzby > > wrote in > > > I agree that this is a bug, since it can (and did) cause false positives > > > in a > > > monitoring system. >

Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-08 Thread Robert Haas
On Thu, Jul 7, 2022 at 10:39 PM Kyotaro Horiguchi wrote: > At Thu, 7 Jul 2022 13:58:06 -0500, Justin Pryzby wrote > in > > I agree that this is a bug, since it can (and did) cause false positives in > > a > > monitoring system. > > I'm not this is undoubtfully a bug but agree about the rest.

Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-07 Thread Kyotaro Horiguchi
At Thu, 7 Jul 2022 13:58:06 -0500, Justin Pryzby wrote in > I agree that this is a bug, since it can (and did) cause false positives in a > monitoring system. I'm not this is undoubtfully a bug but agree about the rest. > > As well, patch changes way to allocate memory for local structure.

Re: [PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-07-07 Thread Justin Pryzby
On Thu, Jun 30, 2022 at 11:05:28PM +0300, Michael Zhilin wrote: > I would like to submit patch for column wait_event of view pg_stat_activity. > Please find it attached. Thanks. I had this thread on my list to look at later but then, by chance, I got an erroneous nagios notification about a

[PATCH] fix wait_event of pg_stat_activity in case of high amount of connections

2022-06-30 Thread Michael Zhilin
Hi, I would like to submit patch for column wait_event of view pg_stat_activity. Please find it attached. The view pg_stat_activity provides snapshot of actual backends' state with following columns: - wait_event contains event name for which backend is waiting for; - state of backend,