Re: [PATCH] improve the pg_upgrade error message

2022-03-24 Thread Daniel Gustafsson
> On 1 Dec 2021, at 11:15, Daniel Gustafsson wrote: > >> On 1 Dec 2021, at 10:59, Jeevan Ladhe wrote: > >> Was wondering if we had any barriers to getting this committed. > > No barrier other than available time to, I will try to get to it shortly. The "shortly" aspect wasn't really fulfilled

Re: [PATCH] improve the pg_upgrade error message

2021-12-01 Thread Jeevan Ladhe
On Wed, Dec 1, 2021 at 3:45 PM Daniel Gustafsson wrote: > > On 1 Dec 2021, at 10:59, Jeevan Ladhe > wrote: > > > Was wondering if we had any barriers to getting this committed. > > No barrier other than available time to, I will try to get to it shortly. > Great! Thank you. > -- > Daniel Gust

Re: [PATCH] improve the pg_upgrade error message

2021-12-01 Thread Daniel Gustafsson
> On 1 Dec 2021, at 10:59, Jeevan Ladhe wrote: > Was wondering if we had any barriers to getting this committed. No barrier other than available time to, I will try to get to it shortly. -- Daniel Gustafsson https://vmware.com/

Re: [PATCH] improve the pg_upgrade error message

2021-12-01 Thread Jeevan Ladhe
Hi Daniel, Was wondering if we had any barriers to getting this committed. I believe it will be good to have this change and also it will be more in line with other check functions also. Regards, Jeevan On Thu, Oct 21, 2021 at 3:51 PM Daniel Gustafsson wrote: > > On 14 Jul 2021, at 07:27, Sura

Re: [PATCH] improve the pg_upgrade error message

2021-10-21 Thread Daniel Gustafsson
> On 14 Jul 2021, at 07:27, Suraj Kharage > wrote: > Overall patch looks good to me. Agreed, I think this is a good change and in line with how the check functions work in general. > Instead of giving suggestion about updating the pg_database catalog, can we > give "ALTER DATABASE ALLOW_CONN

Re: [PATCH] improve the pg_upgrade error message

2021-07-13 Thread Suraj Kharage
Thanks Jeevan for working on this. Overall patch looks good to me. + pg_fatal("All non-template0 databases must allow connections, i.e. their\n" + "pg_database.datallowconn must be true. Your installation contains\n" + "non-template0 databases with their pg_database.datallowconn set to\n" + "false

Re: [PATCH] improve the pg_upgrade error message

2021-07-13 Thread Jeevan Ladhe
> The admin might fix DB123, restart their upgrade procedure, spend 5 or 15 > minutes with that, only to have it then fail on DB1234. > Agree with this observation. Here is a patch that writes the list of all the databases other than template0 that are having their pg_database.datallowconn to fal

Re: [PATCH] improve the pg_upgrade error message

2021-07-12 Thread Justin Pryzby
On Mon, Jul 12, 2021 at 02:06:31PM +0200, Laurenz Albe wrote: > On Mon, 2021-07-12 at 16:58 +0530, Jeevan Ladhe wrote: > > While looking into one of the pg_upgrade issue, I found it > > challenging to find out the database that has the datallowconn set to > > 'false' that was throwing following err

Re: [PATCH] improve the pg_upgrade error message

2021-07-12 Thread Suraj Kharage
+1 for the change. Patch looks good to me. On Mon, Jul 12, 2021 at 4:59 PM Jeevan Ladhe wrote: > While looking into one of the pg_upgrade issue, I found it > > challenging to find out the database that has the datallowconn set to > > 'false' that was throwing following error: > > > *"All non-tem

Re: [PATCH] improve the pg_upgrade error message

2021-07-12 Thread Laurenz Albe
On Mon, 2021-07-12 at 16:58 +0530, Jeevan Ladhe wrote: > While looking into one of the pg_upgrade issue, I found it > challenging to find out the database that has the datallowconn set to > 'false' that was throwing following error: > > "All non-template0 databases must allow connections, i.e. the

[PATCH] improve the pg_upgrade error message

2021-07-12 Thread Jeevan Ladhe
While looking into one of the pg_upgrade issue, I found it challenging to find out the database that has the datallowconn set to 'false' that was throwing following error: *"All non-template0 databases must allow connections, i.e. their pg_database.datallowconn must be true"* edb=# create dat