Re: [PROPOSAL] new diagnostic items for the dynamic sql

2022年8月3日(水) 7:56 Tom Lane : > > Jacob Champion writes: > > ...and Dinesh's email has just bounced back undelivered. :( > > > Anybody interested in running with this? If no one speaks up, I think we > > should return this as "needs more interest" before the next CF starts. > > Meh ... the last

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Jacob Champion writes: > ...and Dinesh's email has just bounced back undelivered. :( > Anybody interested in running with this? If no one speaks up, I think we > should return this as "needs more interest" before the next CF starts. Meh ... the last versions of the patch were far too invasive

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On 8/2/22 15:09, Jacob Champion wrote: > I've carried it forward, but it needs some help to keep from stalling > out. Definitely make sure it's rebased and up to date by the time the > next CF starts, to give it the best chance at getting additional review > (if you haven't received any by then).

Re: [PROPOSAL] new diagnostic items for the dynamic sql

>From looking at this patch and its history [1, 2], I think momentum was probably lost during the January CF, where this patch was unregistered (presumably by accident). I've carried it forward, but it needs some help to keep from stalling out. Definitely make sure it's rebased and up to date by

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi Everyone, Let me know if anything else is needed on my end On Fri, 17 Dec 2021 at 10:54, Dinesh Chemuduru wrote: > > > On Fri, 3 Dec 2021 at 22:04, Zhihong Yu wrote: > >> >> >> On Fri, Dec 3, 2021 at 3:15 AM Dinesh Chemuduru >> wrote: >> >>> Hi Michael, >>> >>> Attaching the latest patch

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Fri, 3 Dec 2021 at 22:04, Zhihong Yu wrote: > > > On Fri, Dec 3, 2021 at 3:15 AM Dinesh Chemuduru > wrote: > >> Hi Michael, >> >> Attaching the latest patch here(It's the recent patch), and looking for >> more suggestions/inputs from the team. >> >> On Fri, 3 Dec 2021 at 13:09, Michael

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Fri, Dec 3, 2021 at 3:15 AM Dinesh Chemuduru wrote: > Hi Michael, > > Attaching the latest patch here(It's the recent patch), and looking for > more suggestions/inputs from the team. > > On Fri, 3 Dec 2021 at 13:09, Michael Paquier wrote: > >> On Wed, Nov 10, 2021 at 01:58:58PM +0530, Dinesh

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi Michael, Attaching the latest patch here(It's the recent patch), and looking for more suggestions/inputs from the team. On Fri, 3 Dec 2021 at 13:09, Michael Paquier wrote: > On Wed, Nov 10, 2021 at 01:58:58PM +0530, Dinesh Chemuduru wrote: > > The proposed statements are much clear, but

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Wed, Nov 10, 2021 at 01:58:58PM +0530, Dinesh Chemuduru wrote: > The proposed statements are much clear, but will wait for other’s > suggestion, and will fix it accordingly. This update was three weeks ago, and no new version has been provided, so I am marking this as returned with feedback in

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Thanks for your time Pavel > On 09-Nov-2021, at 13:32, Pavel Stehule wrote: > >  > Hi > > po 8. 11. 2021 v 9:57 odesílatel Dinesh Chemuduru > napsal: >> Thanks Zhihong/Pavel, >> >>> On Mon, 8 Nov 2021 at 10:03, Pavel Stehule wrote: >>> >>> >>> po 8. 11. 2021 v 5:24 odesílatel Pavel

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi po 8. 11. 2021 v 9:57 odesílatel Dinesh Chemuduru napsal: > Thanks Zhihong/Pavel, > > On Mon, 8 Nov 2021 at 10:03, Pavel Stehule > wrote: > >> >> >> po 8. 11. 2021 v 5:24 odesílatel Pavel Stehule >> napsal: >> >>> >>> >>> po 8. 11. 2021 v 5:07 odesílatel Pavel Stehule >>> napsal: >>>

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Thanks Zhihong/Pavel, On Mon, 8 Nov 2021 at 10:03, Pavel Stehule wrote: > > > po 8. 11. 2021 v 5:24 odesílatel Pavel Stehule > napsal: > >> >> >> po 8. 11. 2021 v 5:07 odesílatel Pavel Stehule >> napsal: >> >>> +set_errcurrent_query (const char *query) You can remove the

Re: [PROPOSAL] new diagnostic items for the dynamic sql

po 8. 11. 2021 v 5:24 odesílatel Pavel Stehule napsal: > > > po 8. 11. 2021 v 5:07 odesílatel Pavel Stehule > napsal: > >> >>> >>> +set_errcurrent_query (const char *query) >>> >>> You can remove the space prior to (. >>> I wonder if the new field can be named current_err_query because that's

Re: [PROPOSAL] new diagnostic items for the dynamic sql

po 8. 11. 2021 v 5:07 odesílatel Pavel Stehule napsal: > >> >> +set_errcurrent_query (const char *query) >> >> You can remove the space prior to (. >> I wonder if the new field can be named current_err_query because that's >> what the setter implies. >> current_query may give the impression that

Re: [PROPOSAL] new diagnostic items for the dynamic sql

> > > > +set_errcurrent_query (const char *query) > > You can remove the space prior to (. > I wonder if the new field can be named current_err_query because that's > what the setter implies. > current_query may give the impression that the field can store normal > query (which doesn't cause

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Sun, Nov 7, 2021 at 5:23 AM Dinesh Chemuduru wrote: > Hi Pavel, > > On Sun, 7 Nov 2021 at 12:53, Pavel Stehule > wrote: > >> Hi >> >> pá 5. 11. 2021 v 19:27 odesílatel Dinesh Chemuduru < >> dinesh.ku...@migops.com> napsal: >> >>> Hi Daniel, >>> >>> Thank you for your follow up, and attaching

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi Pavel, On Sun, 7 Nov 2021 at 12:53, Pavel Stehule wrote: > Hi > > pá 5. 11. 2021 v 19:27 odesílatel Dinesh Chemuduru < > dinesh.ku...@migops.com> napsal: > >> Hi Daniel, >> >> Thank you for your follow up, and attaching a new patch which addresses >> Pavel's comments. >> Let me know If I

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi pá 5. 11. 2021 v 19:27 odesílatel Dinesh Chemuduru napsal: > Hi Daniel, > > Thank you for your follow up, and attaching a new patch which addresses > Pavel's comments. > Let me know If I miss anything here. > > > On Thu, 4 Nov 2021 at 17:40, Daniel Gustafsson wrote: > >> > On 9 Sep 2021, at

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi Daniel, Thank you for your follow up, and attaching a new patch which addresses Pavel's comments. Let me know If I miss anything here. On Thu, 4 Nov 2021 at 17:40, Daniel Gustafsson wrote: > > On 9 Sep 2021, at 08:23, Dinesh Chemuduru > wrote: > > > Let me try to fix the suggested case(I

Re: [PROPOSAL] new diagnostic items for the dynamic sql

> On 9 Sep 2021, at 08:23, Dinesh Chemuduru wrote: > Let me try to fix the suggested case(I tried to fix this case in the past, > but this time I will try to spend more time on this), and will submit a new > patch. This CF entry is marked Waiting on Author, have you had the chance to prepare

Re: [PROPOSAL] new diagnostic items for the dynamic sql

čt 9. 9. 2021 v 8:23 odesílatel Dinesh Chemuduru napsal: > > > On Thu, 9 Sept 2021 at 11:07, Pavel Stehule > wrote: > >> Hi >> >> I tested the last patch, and I think I found unwanted behavior. >> >> The value of PG_SQL_TEXT is not empty only when the error is related to >> the parser stage.

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Thu, 9 Sept 2021 at 11:07, Pavel Stehule wrote: > Hi > > I tested the last patch, and I think I found unwanted behavior. > > The value of PG_SQL_TEXT is not empty only when the error is related to > the parser stage. When the error is raised in the query evaluation stage, > then the value is

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi I tested the last patch, and I think I found unwanted behavior. The value of PG_SQL_TEXT is not empty only when the error is related to the parser stage. When the error is raised in the query evaluation stage, then the value is empty. I think this is too confusing. PL/pgSQL is a high level

Re: [PROPOSAL] new diagnostic items for the dynamic sql

út 24. 8. 2021 v 8:16 odesílatel Dinesh Chemuduru napsal: > Hi Pavel, > > On Tue, 24 Aug 2021 at 00:19, Pavel Stehule > wrote: > >> Hi >> >> pá 20. 8. 2021 v 10:24 odesílatel Dinesh Chemuduru < >> dinesh.ku...@migops.com> napsal: >> >>> On Sun, 25 Jul 2021 at 16:34, Pavel Stehule >>> wrote:

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi Pavel, On Tue, 24 Aug 2021 at 00:19, Pavel Stehule wrote: > Hi > > pá 20. 8. 2021 v 10:24 odesílatel Dinesh Chemuduru < > dinesh.ku...@migops.com> napsal: > >> On Sun, 25 Jul 2021 at 16:34, Pavel Stehule >> wrote: >> > > please, can you register this patch to commitfest app > >

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi pá 20. 8. 2021 v 10:24 odesílatel Dinesh Chemuduru napsal: > On Sun, 25 Jul 2021 at 16:34, Pavel Stehule > wrote: > please, can you register this patch to commitfest app https://commitfest.postgresql.org/34/ Regards Pavel > >> >> ne 25. 7. 2021 v 12:52 odesílatel Dinesh Chemuduru < >>

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Sun, 25 Jul 2021 at 16:34, Pavel Stehule wrote: > > > ne 25. 7. 2021 v 12:52 odesílatel Dinesh Chemuduru < > dinesh.ku...@migops.com> napsal: > >> On Sat, 17 Jul 2021 at 01:29, Pavel Stehule >> wrote: >> >>> Hi >>> >>> pá 16. 7. 2021 v 21:47 odesílatel Dinesh Chemuduru < >>>

Re: [PROPOSAL] new diagnostic items for the dynamic sql

ne 25. 7. 2021 v 12:52 odesílatel Dinesh Chemuduru napsal: > On Sat, 17 Jul 2021 at 01:29, Pavel Stehule > wrote: > >> Hi >> >> pá 16. 7. 2021 v 21:47 odesílatel Dinesh Chemuduru < >> dinesh.ku...@migops.com> napsal: >> >>> Hi Everyone, >>> >>> We would like to propose the below 2 new plpgsql

Re: [PROPOSAL] new diagnostic items for the dynamic sql

On Sat, 17 Jul 2021 at 01:29, Pavel Stehule wrote: > Hi > > pá 16. 7. 2021 v 21:47 odesílatel Dinesh Chemuduru < > dinesh.ku...@migops.com> napsal: > >> Hi Everyone, >> >> We would like to propose the below 2 new plpgsql diagnostic items, >> related to parsing. Because, the current diag items

Re: [PROPOSAL] new diagnostic items for the dynamic sql

Hi pá 16. 7. 2021 v 21:47 odesílatel Dinesh Chemuduru napsal: > Hi Everyone, > > We would like to propose the below 2 new plpgsql diagnostic items, > related to parsing. Because, the current diag items are not providing > the useful diagnostics about the dynamic SQL statements. > > 1.

[PROPOSAL] new diagnostic items for the dynamic sql

Hi Everyone, We would like to propose the below 2 new plpgsql diagnostic items, related to parsing. Because, the current diag items are not providing the useful diagnostics about the dynamic SQL statements. 1. PG_PARSE_SQL_STATEMENT (returns parse failed sql statement) 2.