Re: [Patch] Base backups and random or zero pageheaders

2020-02-25 Thread Michael Banck
Hi, Am Dienstag, den 25.02.2020, 19:34 +0500 schrieb Asif Rehman: > On Fri, Oct 18, 2019 at 2:06 PM Michael Banck > wrote: > > Here is finally a rebased patch for the (IMO) more important issue in > > pg_basebackup. I've added a commitfest entry for this now: > > https://commitfest.postgresql.o

Re: [Patch] Base backups and random or zero pageheaders

2020-02-25 Thread Asif Rehman
On Fri, Oct 18, 2019 at 2:06 PM Michael Banck wrote: > Hi, > > Am Samstag, den 04.05.2019, 21:50 +0900 schrieb Michael Paquier: > > On Tue, Apr 30, 2019 at 03:07:43PM +0200, Michael Banck wrote: > > > This is still an open item for the back branches I guess, i.e. zero > page > > > header for pg_v

Re: [Patch] Base backups and random or zero pageheaders

2019-10-18 Thread Michael Banck
Hi, Am Samstag, den 04.05.2019, 21:50 +0900 schrieb Michael Paquier: > On Tue, Apr 30, 2019 at 03:07:43PM +0200, Michael Banck wrote: > > This is still an open item for the back branches I guess, i.e. zero page > > header for pg_verify_checksums and additionally random page header for > > pg_baseb

Re: [Patch] Base backups and random or zero pageheaders

2019-05-04 Thread Michael Paquier
On Tue, Apr 30, 2019 at 03:07:43PM +0200, Michael Banck wrote: > This is still an open item for the back branches I guess, i.e. zero page > header for pg_verify_checksums and additionally random page header for > pg_basebackup's base backup. I may be missing something, but could you add an entry i

Re: [Patch] Base backups and random or zero pageheaders

2019-04-30 Thread Michael Banck
Hi, Am Mittwoch, den 27.03.2019, 11:37 +0100 schrieb Michael Banck: > Am Dienstag, den 26.03.2019, 19:23 +0100 schrieb Michael Banck: > > Am Dienstag, den 26.03.2019, 10:30 -0700 schrieb Andres Freund: > > > On 2019-03-26 18:22:55 +0100, Michael Banck wrote: > > > >

Re: [Patch] Base backups and random or zero pageheaders

2019-03-27 Thread Michael Banck
Hi, Am Dienstag, den 26.03.2019, 19:23 +0100 schrieb Michael Banck: > Am Dienstag, den 26.03.2019, 10:30 -0700 schrieb Andres Freund: > > On 2019-03-26 18:22:55 +0100, Michael Banck wrote: > > > /* > > > - * Only check pages which have not been >

Re: [Patch] Base backups and random or zero pageheaders (was: Online verification of checksums)

2019-03-26 Thread Michael Banck
Hi, Am Dienstag, den 26.03.2019, 10:30 -0700 schrieb Andres Freund: > On 2019-03-26 18:22:55 +0100, Michael Banck wrote: > > Am Dienstag, den 19.03.2019, 13:00 -0700 schrieb Andres Freund: > > > CREATE TABLE corruptme AS SELECT g.i::text AS data FROM > > > generate_series(1, 100) g(i); > > >

Re: [Patch] Base backups and random or zero pageheaders (was: Online verification of checksums)

2019-03-26 Thread Andres Freund
On 2019-03-26 18:22:55 +0100, Michael Banck wrote: > Hi, > > Am Dienstag, den 19.03.2019, 13:00 -0700 schrieb Andres Freund: > > CREATE TABLE corruptme AS SELECT g.i::text AS data FROM generate_series(1, > > 100) g(i); > > SELECT pg_relation_size('corruptme'); > > postgres[22890][1]=# SELECT

[Patch] Base backups and random or zero pageheaders (was: Online verification of checksums)

2019-03-26 Thread Michael Banck
Hi, Am Dienstag, den 19.03.2019, 13:00 -0700 schrieb Andres Freund: > CREATE TABLE corruptme AS SELECT g.i::text AS data FROM generate_series(1, > 100) g(i); > SELECT pg_relation_size('corruptme'); > postgres[22890][1]=# SELECT current_setting('data_directory') || '/' || > pg_relation_filepa