Hello, hackers,
I think there may be some duplicated codes.
Function smgrDoPendingDeletes() calls both smgrdounlinkall() and
smgrclose().
But both functions would close SMgrRelation object, it's dupliacted
behavior?
So I make this patch. Could someone take a look at it?
Thanks for your help,
Ste
Hi Steven,
On Wed, Jul 31, 2024 at 11:16 AM Steven Niu wrote:
>
> Hello, hackers,
>
> I think there may be some duplicated codes.
> Function smgrDoPendingDeletes() calls both smgrdounlinkall() and smgrclose().
> But both functions would close SMgrRelation object, it's dupliacted behavior?
>
> So
Hi, Junwang,
Thank you for the review and excellent summary in commit message!
This is my first contribution to community, and not so familiar with the
overall process.
After reading the process again, it looks like that I'm not qualified to
submit the patch to commitfest as I never had reviewed
Hi Steven,
On Fri, Aug 2, 2024 at 12:12 PM Steven Niu wrote:
>
> Hi, Junwang,
>
> Thank you for the review and excellent summary in commit message!
>
> This is my first contribution to community, and not so familiar with the
> overall process.
> After reading the process again, it looks like tha
Thanks, I have set my name in the Authors column of CF.
Steven
Junwang Zhao 于2024年8月2日周五 13:22写道：
> Hi Steven,
>
> On Fri, Aug 2, 2024 at 12:12 PM Steven Niu wrote:
> >
> > Hi, Junwang,
> >
> > Thank you for the review and excellent summary in commit message!
> >
> > This is my first contribut
On Thu, 1 Aug 2024 at 17:32, Junwang Zhao wrote:
>
> Hi Steven,
>
> On Wed, Jul 31, 2024 at 11:16 AM Steven Niu wrote:
> >
> > Hello, hackers,
> >
> > I think there may be some duplicated codes.
> > Function smgrDoPendingDeletes() calls both smgrdounlinkall() and
> > smgrclose().
> > But both fu
On Fri, Aug 9, 2024 at 5:20 PM Kirill Reshke wrote:
>
> On Thu, 1 Aug 2024 at 17:32, Junwang Zhao wrote:
> >
> > Hi Steven,
> >
> > On Wed, Jul 31, 2024 at 11:16 AM Steven Niu wrote:
> > >
> > > Hello, hackers,
> > >
> > > I think there may be some duplicated codes.
> > > Function smgrDoPendingD
Kirill,
Good catch!
I will split the patch into two to cover both cases.
Thanks,
Steven
Junwang Zhao 于2024年8月9日周五 18:19写道：
> On Fri, Aug 9, 2024 at 5:20 PM Kirill Reshke
> wrote:
> >
> > On Thu, 1 Aug 2024 at 17:32, Junwang Zhao wrote:
> > >
> > > Hi Steven,
> > >
> > > On Wed, Jul 31, 2024
Junwang, Kirill,
The split work has been done. I created a new patch for removing
redundant smgrclose() function as attached.
Please help review it.
Thanks,
Steven
Steven Niu 于2024年8月12日周一 18:11写道：
> Kirill,
>
> Good catch!
> I will split the patch into two to cover both cases.
>
> Thanks,
> S
On Wed, Aug 14, 2024 at 2:35 PM Steven Niu wrote:
>
> Junwang, Kirill,
>
> The split work has been done. I created a new patch for removing redundant
> smgrclose() function as attached.
> Please help review it.
Patch looks good, actually you can make the refactoring code as v3-0002-xxx
by using:
Junwang Zhao 于2024年8月15日周四 18:03写道：
> On Wed, Aug 14, 2024 at 2:35 PM Steven Niu wrote:
> >
> > Junwang, Kirill,
> >
> > The split work has been done. I created a new patch for removing
> redundant smgrclose() function as attached.
> > Please help review it.
>
> Patch looks good, actually you ca
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hi
the patch looks good to me as well. Calling smgrclose() right after calli
12 matches
Mail list logo
