Re: [patch] Fix pg_checksums to allow checking of offline base backup directories

2020-04-07 Thread Michael Banck
Hi, Am Dienstag, den 07.04.2020, 17:07 +0900 schrieb Michael Paquier: > On Mon, Apr 06, 2020 at 01:26:17PM +0200, Michael Banck wrote: > > I think we can allow checking of base backups if we make sure > > backup_label exists in the data directory or am I missing something? > > I think we need to h

Re: [patch] Fix pg_checksums to allow checking of offline base backup directories

2020-04-07 Thread Michael Paquier
On Mon, Apr 06, 2020 at 01:26:17PM +0200, Michael Banck wrote: > I think we can allow checking of base backups if we make sure > backup_label exists in the data directory or am I missing something? > I think we need to have similar checks about pages changed during base > backup, so this patch igno

[patch] Fix pg_checksums to allow checking of offline base backup directories

2020-04-06 Thread Michael Banck
Hi, Right now, pg_checksums cannot check a base backup directory taken by pg_basebackup: initdb -k data > /dev/null pg_ctl -D data -l logfile start > /dev/null pg_basebackup -D data_backup pg_checksums -D data_backup pg_checksums: error: cluster must be shut down So users need to start and then