Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-03-06 Thread Andres Freund
Hi, On 2020-02-26 16:52:13 +0100, Sandro Santilli wrote: > This part is not clear to me. You're _assuming_ that the unpackaged--xxx > will not make checks, so you _drop_ support for it ? Can't the normal > extension script also be unsafe for some reason ? Yes. But it's at least plausible to make

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-27 Thread Sandro Santilli
On Thu, Feb 27, 2020 at 09:32:24AM +0100, Sandro Santilli wrote: > On Wed, Feb 26, 2020 at 11:18:43AM -0500, Chapman Flack wrote: > > On 2/26/20 10:52 AM, Sandro Santilli wrote: > > > > > This part is not clear to me. You're _assuming_ that the unpackaged--xxx > > > will not make checks, so you

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-27 Thread Sandro Santilli
On Wed, Feb 26, 2020 at 11:18:43AM -0500, Chapman Flack wrote: > On 2/26/20 10:52 AM, Sandro Santilli wrote: > > > This part is not clear to me. You're _assuming_ that the unpackaged--xxx > > will not make checks, so you _drop_ support for it ? Can't the normal > > extension script also be unsafe

RE: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Regina Obe
> Presumably 15 years out from the 1.x -> 2.x we can stop worrying about > bundling unpackaged postgis into an extension, and just recommend a hard > upgrade dump/restore to the hardy souls still running 1.x. > > P. > We don't need to worry about 1.x cause 1.x can only do a hard upgrade to 2 or

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Chapman Flack
On 2/26/20 10:52 AM, Sandro Santilli wrote: > This part is not clear to me. You're _assuming_ that the unpackaged--xxx > will not make checks, so you _drop_ support for it ? Can't the normal > extension script also be unsafe for some reason ? Or can't the > unpackaged-xxx script be made safe by

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Paul Ramsey
OK, well, what PostGIS needs is the ability for 'ALTER EXTENSION …. UPDATE foo’ to end up with two extensions in the end, ‘foo’ and ‘foo_new’. That’s what’s happening in the 2.x -> 3 upgrade process, as ‘postgis’ becomes ‘postgis’ and ‘postgis_raster’. Presumably 15 years out from the 1.x ->

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Sandro Santilli
On Wed, Feb 26, 2020 at 10:37:41AM -0500, Stephen Frost wrote: > Greetings, > > * Sandro Santilli (s...@kbt.io) wrote: > > On pgsql-hackers we only want to find a future-proof way to "package > > existing objects into an extension". If the syntax > > `CREATE EXTENSION FROM UNPACKAGED` > > has

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Stephen Frost
Greetings, * Sandro Santilli (s...@kbt.io) wrote: > On pgsql-hackers we only want to find a future-proof way to "package > existing objects into an extension". If the syntax > `CREATE EXTENSION FROM UNPACKAGED` > has gone, would it be ok for just: > `CREATE EXTENSION ` > to intercept

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Sandro Santilli
On Wed, Feb 26, 2020 at 03:35:46PM +0100, Daniel Gustafsson wrote: > > On 26 Feb 2020, at 15:13, Sandro Santilli wrote: > > > On pgsql-hackers we only want to find a future-proof way to "package > > existing objects into an extension". > > What is the longterm goal of PostGIS, to use this as a

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Daniel Gustafsson
> On 26 Feb 2020, at 15:13, Sandro Santilli wrote: > On pgsql-hackers we only want to find a future-proof way to "package > existing objects into an extension". What is the longterm goal of PostGIS, to use this as a stepping stone to reach a point where no unpackaged extensions exist; or find a

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Sandro Santilli
On Wed, Feb 26, 2020 at 08:55:03AM -0500, Stephen Frost wrote: > Greetings, > > * Darafei "Komяpa" Praliaskouski (m...@komzpa.net) wrote: > > PostGIS 2.5 had raster and vector blended together in single extension. > > In PostGIS 3, they were split out into postgis and postgis_raster > >

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-26 Thread Stephen Frost
Greetings, * Darafei "Komяpa" Praliaskouski (m...@komzpa.net) wrote: > PostGIS 2.5 had raster and vector blended together in single extension. > In PostGIS 3, they were split out into postgis and postgis_raster extensions. For my 2c, at least, I still don't really get why that split was done. >

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-25 Thread Tom Lane
=?UTF-8?Q?Darafei_=22Kom=D1=8Fpa=22_Praliaskouski?= writes: > Removal of FROM UNPACKAGED breaks PostGIS 2.5 -> 3.0 upgrade path, and > we haven't yet found a proper replacement since such removal wasn't > something we were expecting. I'd agree with Stephen's comment: > On Tue, Feb 25, 2020 at

Re: [postgis-devel] About EXTENSION from UNPACKAGED on PostgreSQL 13

2020-02-25 Thread Komяpa
Hi, PostGIS 2.5 had raster and vector blended together in single extension. In PostGIS 3, they were split out into postgis and postgis_raster extensions. To upgrade, there is now postgis_extensions_upgrade() function, that unpackages the raster part out of postgis extensions, upgrades it, and