At Tue, 12 May 2020 14:45:22 +0900, Michael Paquier wrote
in
> On Mon, May 11, 2020 at 02:22:36PM +0900, Michael Paquier wrote:
> > Looks right to me, so will fix if there are no objections.
> > read_local_xlog_page() uses the replay location when in recovery.
>
> Done this part now.
Thanks!
On Mon, May 11, 2020 at 02:22:36PM +0900, Michael Paquier wrote:
> Looks right to me, so will fix if there are no objections.
> read_local_xlog_page() uses the replay location when in recovery.
Done this part now.
--
Michael
signature.asc
Description: PGP signature
On Mon, May 11, 2020 at 10:16:19AM +0900, Kyotaro Horiguchi wrote:
> The comment is mentioning "replay position" and the callers are
> actually using GetXLogReplayRecPtr to check TLI and target LSN. The
> comment was written in that way when the function is introduced by
> 1148e22a82. The attached
Hello.
I happened to notice a wrong function name in the comment of
XLogReadDetermineTimeline.
* The caller must also make sure it doesn't read past the current replay
* position (using GetWalRcvWriteRecPtr) if executing in recovery, so it
The comment is mentioning "replay position" and the ca
At Thu, 26 Sep 2019 11:57:59 +0900, Michael Paquier wrote
in <20190926025759.gb2...@paquier.xyz>
> On Thu, Sep 26, 2019 at 11:08:09AM +0900, Kyotaro Horiguchi wrote:
> > While rechecking another patch, I found that 709d003fbd forgot to
> > edit a comment mentioning three members removed from
> >
On Thu, Sep 26, 2019 at 11:08:09AM +0900, Kyotaro Horiguchi wrote:
> While rechecking another patch, I found that 709d003fbd forgot to
> edit a comment mentioning three members removed from
> XLogReaderState.
>
@@ -103,8 +103,7 @@ XLogReaderAllocate(int wal_segment_size, const char *waldir,
st
While rechecking another patch, I found that 709d003fbd forgot to
edit a comment mentioning three members removed from
XLogReaderState.
See the attached.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/trans
