Re: A few warnings on Windows

On Fri, May 4, 2018 at 2:46 AM, Peter Eisentraut wrote: > On 5/3/18 10:18, Tom Lane wrote: >> Christian Ullrich writes: Thomas Munro writes: > Does anyone know what line 174 of pyconfig.h happens to

Re: A few warnings on Windows

On 5/3/18 10:18, Tom Lane wrote: > Christian Ullrich writes: >>> Thomas Munro writes: Does anyone know what line 174 of pyconfig.h happens to say? > >> typedef _W64 int ssize_t; >> , in a "not for 64-bit" block. >>

Re: A few warnings on Windows

Christian Ullrich writes: >> Thomas Munro writes: >>> Does anyone know what line 174 of pyconfig.h happens to say? > typedef _W64 int ssize_t; > , in a "not for 64-bit" block. > ,

Re: A few warnings on Windows

* Tom Lane wrote: Thomas Munro writes: One more problem. whelk builds against Python 3.6 and says: c:\users\pgbf\appdata\local\programs\python\python36-32\include\pyconfig.h(174): warning C4142: benign redefinition of type (src/pl/plpython/plpy_elog.c)

Re: A few warnings on Windows

On Thu, May 03, 2018 at 09:03:15AM +1200, Thomas Munro wrote: > On Thu, May 3, 2018 at 8:01 AM, Tom Lane wrote: > Build succeeded. > 0 Warning(s) > 0 Error(s) > > Huzzah! Great work. This has been some time... -- Michael signature.asc Description: PGP signature

Re: A few warnings on Windows

Thomas Munro writes: > One more problem. whelk builds against Python 3.6 and says: > c:\users\pgbf\appdata\local\programs\python\python36-32\include\pyconfig.h(174): > warning C4142: benign redefinition of type > (src/pl/plpython/plpy_elog.c) >

Re: A few warnings on Windows

On Thu, May 3, 2018 at 8:01 AM, Tom Lane wrote: > Seems reasonable to me. Pushed, we'll see what the buildfarm thinks. Build succeeded. 0 Warning(s) 0 Error(s) Huzzah! One more problem. whelk builds against Python 3.6 and says:

Re: A few warnings on Windows

Thomas Munro writes: > The only remaining warnings on those machines now come from the fact > that our port_win32.h and Perl's XSUB.h both want to define macros to > define macros for libc functions like mkdir etc. plperl.h already > seems to deal with other

Re: A few warnings on Windows

On Wed, May 2, 2018 at 4:28 PM, Tom Lane wrote: > Thomas Munro writes: >> That compiles and runs the main checks (except tablespace which I >> suppress) cleanly for me and I assume it really is using >> stdbool.h this time. Hopefully plperl

Re: A few warnings on Windows

Thomas Munro writes: > On Wed, May 2, 2018 at 12:51 PM, Thomas Munro > wrote: >> Perhaps that's what Peter E meant when he said "Windows could use some >> manual adjustments in pg_config.h.win32 if anyone >> cares"[1]. Should we just

Re: A few warnings on Windows

Andres Freund writes: > On 2018-05-01 22:55:47 -0400, Peter Eisentraut wrote: >> On 5/1/18 16:48, Tom Lane wrote: >>> ... Perhaps at some point we should have configure turn that >>> warning on if available? >> I think it's useful, but I have found it a bit fickle at times.

Re: A few warnings on Windows

On 2018-05-01 22:55:47 -0400, Peter Eisentraut wrote: > On 5/1/18 16:48, Tom Lane wrote: > > On more or less the same topic, I just scraped all the compiler warnings > > for HEAD from the buildfarm database, and there seem to be a few other > > things worth cleaning up. One that I'm looking at is

Re: A few warnings on Windows

On 5/1/18 16:48, Tom Lane wrote: > On more or less the same topic, I just scraped all the compiler warnings > for HEAD from the buildfarm database, and there seem to be a few other > things worth cleaning up. One that I'm looking at is that recent gcc > has a -Wimplicit-fallthrough warning for

Re: A few warnings on Windows

On Wed, May 2, 2018 at 12:51 PM, Thomas Munro wrote: > On Wed, May 2, 2018 at 11:39 AM, Tom Lane wrote: >> We'll soon find out. > > Nope -- and I think that's because we only actually use stdbool.h > instead of our own macros if we think

Re: A few warnings on Windows

On Wed, May 2, 2018 at 11:39 AM, Tom Lane wrote: > Thomas Munro writes: >> Here's a patch that builds warning-free for me. Result: >> https://ci.appveyor.com/project/macdice/postgres/build/1.0.139 > > LGTM, pushed. Thanks. The first two

Re: A few warnings on Windows

Thomas Munro writes: > Here's a patch that builds warning-free for me. Result: > https://ci.appveyor.com/project/macdice/postgres/build/1.0.139 LGTM, pushed. > Unfortunately my scripting for that doesn't actually build the plperl > stuff yet (need to cannibalise

Re: A few warnings on Windows

On Wed, May 2, 2018 at 9:29 AM, Thomas Munro wrote: > On Wed, May 2, 2018 at 8:48 AM, Tom Lane wrote: >> Yeah. In the wake of Peter's changes to use on other >> platforms, should we be enabling HAVE_STDBOOL_H for Windows? > > It seems that

Re: A few warnings on Windows

On Wed, May 2, 2018 at 8:48 AM, Tom Lane wrote: > Yeah. In the wake of Peter's changes to use on other > platforms, should we be enabling HAVE_STDBOOL_H for Windows? It seems that header arrived in VC 2013. I will find the conditional macrology for that.

Re: A few warnings on Windows

Michael Paquier writes: > On Tue, May 01, 2018 at 05:40:18PM +1200, Thomas Munro wrote: >> src/backend/replication/basebackup.c(1470): warning C4146: unary minus >> operator applied to unsigned type, result still unsigned >> ... where cnt is size_t. Perhaps we should use (or

Re: A few warnings on Windows

On Tue, May 01, 2018 at 05:40:18PM +1200, Thomas Munro wrote: > src/backend/replication/basebackup.c(1470): warning C4146: unary minus > operator applied to unsigned type, result still unsigned > > Yeah, we have: if (fseek(fp, -(cnt - BLCKSZ * i), SEEK_CUR) == -1) > > ... where cnt is size_t.