Re: Add LWLock blocker(s) information

2020-11-19 Thread Craig Ringer
On Wed, Nov 18, 2020 at 5:25 PM Heikki Linnakangas wrote: > On 11/08/2020 03:41, Andres Freund wrote: > > On 2020-08-10 18:27:17 -0400, Robert Haas wrote: > >> On Tue, Jun 2, 2020 at 8:25 AM Drouvot, Bertrand > wrote: > >>> the patch adds into the LWLock struct: > >>> > >>>

Re: Add LWLock blocker(s) information

2020-11-18 Thread Heikki Linnakangas
On 11/08/2020 03:41, Andres Freund wrote: On 2020-08-10 18:27:17 -0400, Robert Haas wrote: On Tue, Jun 2, 2020 at 8:25 AM Drouvot, Bertrand wrote: the patch adds into the LWLock struct: last_holding_pid: last pid owner of the lock last_mode: last hold

Re: Add LWLock blocker(s) information

2020-08-12 Thread Peter Geoghegan
On Wed, Aug 12, 2020 at 5:39 PM Andres Freund wrote: > Attached. Needed one python3 fix, and to be adapted so it works with > futex based semaphores. Seems to work for both sysv and posix semaphores > now, based a very short test. Great, thanks! -- Peter Geoghegan

Re: Add LWLock blocker(s) information

2020-08-12 Thread Andres Freund
Hi, On 2020-08-12 16:47:13 -0700, Peter Geoghegan wrote: > On Mon, Aug 10, 2020 at 5:41 PM Andres Freund wrote: > > Most of the cases where this kind of information really is interesting > > seem to benefit a lot from having stack information available. That > > obviously has overhead, so we don

Re: Add LWLock blocker(s) information

2020-08-12 Thread Peter Geoghegan
On Mon, Aug 10, 2020 at 5:41 PM Andres Freund wrote: > Most of the cases where this kind of information really is interesting > seem to benefit a lot from having stack information available. That > obviously has overhead, so we don't want the cost all the > time. The script at > https://postgr.e

Re: Add LWLock blocker(s) information

2020-08-10 Thread Andres Freund
Hi, On 2020-08-10 18:27:17 -0400, Robert Haas wrote: > On Tue, Jun 2, 2020 at 8:25 AM Drouvot, Bertrand wrote: > > the patch adds into the LWLock struct: > > > > last_holding_pid: last pid owner of the lock > > last_mode: last holding mode of the last pid o

Re: Add LWLock blocker(s) information

2020-08-10 Thread Robert Haas
On Tue, Jun 2, 2020 at 8:25 AM Drouvot, Bertrand wrote: > the patch adds into the LWLock struct: > > last_holding_pid: last pid owner of the lock > last_mode: last holding mode of the last pid owner of the > lock > nholders: number of ho

Re: Add LWLock blocker(s) information

2020-08-07 Thread David Zhang
Hi, This is a very interesting topic. I did apply the 2nd patch to master branch and performed a quick test. I can observe below information, postgres=# select * from pg_lwlock_blocking_pid(26925); requested_mode | last_holder_pid | last_holder_mode | nb_holders +---