On Thu, Oct 01, 2020 at 11:18:30AM +0200, Drouvot, Bertrand wrote:
> Had a look at it and did a few tests: looks all good to me.
>
> No objections at all, thanks!
Thanks for double-checking. Applied, then.
--
Michael
signature.asc
Description: PGP signature
On Thu, Sep 24, 2020 at 03:03:46PM +0900, Michael Paquier wrote:
> Hmm. I still think that knowing at least about a FPW could be an
> interesting piece of information even here. Anyway, instead of
> copying a logic that exists already in xlog_outrec(), why not moving
> the block information print
On Mon, Aug 17, 2020 at 05:47:13PM +0200, Drouvot, Bertrand wrote:
> I think it's good to guarantee that we'll always see the same piece of
> information (should a new RM desc() be created in the future for example),
> even if it could lead to some information overlap in some cases.
> I am ok too,
On 2020-Aug-17, Drouvot, Bertrand wrote:
> Having this "pg_waldump" kind of format in this place
> (rm_redo_error_callback()) ensures that we'll always see the same piece of
> information during rm_redo.
>
> I think it's good to guarantee that we'll always see the same piece of
> information (sho
On Tue, 11 Aug 2020 at 15:30, Michael Paquier wrote:
>
> On Tue, Aug 11, 2020 at 02:45:50PM +0900, Masahiko Sawada wrote:
> > Thank you for updating the patch!
> >
> > The patch looks good to me. I've set this patch as Ready for Committer.
>
> + for (block_id = 0; block_id <= record->max_blo
On Tue, Aug 11, 2020 at 02:45:50PM +0900, Masahiko Sawada wrote:
> Thank you for updating the patch!
>
> The patch looks good to me. I've set this patch as Ready for Committer.
+ for (block_id = 0; block_id <= record->max_block_id; block_id++)
+ {
+ RelFileNode rnode;
+
> > the content is safe.
> >
> >
> >
> > On Wed, 5 Aug 2020 at 00:37, Drouvot, Bertrand wrote:
> >> Hi hackers,
> >>
> >> I've attached a small patch to add information to rm_redo_error_callback().
> >>
> >> The changes
On Wed, 5 Aug 2020 at 00:37, Drouvot, Bertrand wrote:
>
> Hi hackers,
>
> I've attached a small patch to add information to rm_redo_error_callback().
>
> The changes attached in this patch came while working on the "Add
> information during standby recovery conf
