Re: Add new wait event to XactLockTableWait

On Mon, Jun 9, 2025 at 6:55 PM Xuneng Zhou wrote: > > Hi Dilip, > > Thanks for looking into this! > > On Mon, Jun 9, 2025 at 6:56 PM Dilip Kumar wrote: >> >> > Thanks for updating the patch! It looks good to me. >> > >> > I think we can mark it as "Ready for Committer" in the CommitFest. >> > Unl

Re: Add new wait event to XactLockTableWait

Hi Fujii-san, On Mon, Jun 9, 2025 at 4:48 PM Fujii Masao wrote: > > Thanks for updating the patch! It looks good to me. > > I think we can mark it as "Ready for Committer" in the CommitFest. > Unless there are any objections, I'll commit it once v19 development opens. > I've marked it as "Ready

Re: Add new wait event to XactLockTableWait

'll commit it once v19 development > opens. > > LGTM, except I suggest using WAIT_EVENT_XACT_COMPLETE instead of > WAIT_EVENT_XACT_DONE. I think it sounds better. > I have renamed it in v3. v3-0001-Add-new-wait-event-to-XactLockTableWait-functions.patch Description: Binary data

Re: Add new wait event to XactLockTableWait

On Mon, Jun 9, 2025 at 2:18 PM Fujii Masao wrote: > > > > On 2025/06/09 14:19, Xuneng Zhou wrote: > > Hi, > > > > On Mon, Jun 9, 2025 at 12:52 PM Xuneng Zhou > > wrote: > > > > > > Hi, > > > > > > > Please find attached Version 2, incorporating the suggested chang

Re: Add new wait event to XactLockTableWait

On 2025/06/09 14:19, Xuneng Zhou wrote: Hi, On Mon, Jun 9, 2025 at 12:52 PM Xuneng Zhou mailto:xunengz...@gmail.com>> wrote: > > Hi, > > > Please find attached Version 2, incorporating the suggested changes. > > Apologies for the confusion — in the previous attempt, I mistakenly > name

Re: Add new wait event to XactLockTableWait

patches and sending emails.😂 Best regards, Xuneng v2-0001-Add-new-wait-event-to-XactLockTableWait-functions.patch Description: Binary data

Re: Add new wait event to XactLockTableWait

ename to follow the proper convention. Best regards, Xuneng v2-0001-Add-new-wait-event-to-XactLockTableWait functions.patch Description: Binary data

Re: Add new wait event to XactLockTableWait

ansaction to finish." > > This could be confusing alongside XACT_DONE. Maybe update it to > something like: > > "Waiting to acquire a transaction ID lock; see linkend='transaction-id'/>." > > This would help users better understand the difference between > the two wait events. I think this is clearer. Please find attached Version 2, incorporating the suggested changes. 0002-Add-new-wait-event-to-XactLockTableWait functions.patch Description: Binary data

Re: Add new wait event to XactLockTableWait

Just CC. On Mon, Jun 9, 2025 at 10:57 AM Xuneng Zhou wrote: > > Hi Michael, > > Thanks for reviewing. > > On Mon, Jun 9, 2025 at 6:41 AM Michael Paquier wrote: > > > + pgstat_report_wait_start(WAIT_EVENT_XACT_DONE); > > [...] > > + pgstat_report_wait_start(WAIT_EVENT_XACT_DONE); > > > >

Re: Add new wait event to XactLockTableWait

On 2025/06/09 7:41, Michael Paquier wrote: On Sun, Jun 08, 2025 at 10:30:45PM +0800, Xuneng Zhou wrote: This is more problematic in logical replication scenarios where these waits can be very long - for example, when creating a logical replication slot on a busy system. Without a specific wai

Re: Add new wait event to XactLockTableWait

On Sun, Jun 08, 2025 at 10:30:45PM +0800, Xuneng Zhou wrote: > This is more problematic in logical replication scenarios where these > waits can be very long - for example, when creating a logical > replication slot on a busy system. Without a specific wait event, it's > hard to distinguish legitim

Add new wait event to XactLockTableWait

Hi hackers, Currently, when XactLockTableWait() and ConditionalXactLockTableWait() sleep waiting for transactions to complete, they don't report any specific wait event to the statistics system. This means that backends stuck in these waits show up in pg_stat_activity with NULL wait_event_type and