On Mon, Mar 28, 2022 at 12:12:48PM +0900, Michael Paquier wrote:
> It seems to me here that the snapshot hold by autovacuum during the
> scan of pg_database to find the relations to process is enough to
> prevent the FSM truncation, as the tuples cleaned up by the DELETE
> query still need to be vi
On Sun, Mar 27, 2022 at 01:18:46PM -0400, Tom Lane wrote:
> skink has passed several runs since the commit went in, so it's
> "unstable" not "fails consistently". I see the test tries to
> disable autovacuum on that table, so that doesn't seem to be
> the problem ... what is?
This is a race condi
Michael Paquier writes:
> Yes, we could extend that more. For now, I am curious to see what the
> buildfarm has to say with the current contents of the patch, and I can
> keep an eye on the buildfarm today, so I have applied it.
It seems this is unstable under valgrind [1]:
---
/mnt/resource/b
On Wed, Mar 23, 2022 at 10:45:19AM -0300, Fabrízio de Royes Mello wrote:
> On Wed, Mar 23, 2022 at 3:05 AM Michael Paquier wrote:
>> Another thing that itched me is that we
>> could also test more with indexes, particularly with btree, BRIN and
>> hash (the latter should not have a FSM with 10 pa
On Wed, Mar 23, 2022 at 3:05 AM Michael Paquier wrote:
>
> After review, I don't like much the idea of allowing concurrent
> autovacuums to run in parallel of the table(s) of this test, so we'd
> better disable it explicitely.
Make sense.
> "t1" is also a very generic name to use in a regressio
On Mon, Mar 21, 2022 at 09:12:37PM +0900, Dong Wook Lee wrote:
> 2022년 3월 20일 (일) 03:13, Fabrízio de Royes Mello 님이
> 작성:
>> On Sat, Mar 19, 2022 at 1:18 PM Dong Wook Lee wrote:
Well, my guess is that you basically just care about being able to
detect if there is free space in the map or
2022년 3월 20일 (일) 03:13, Fabrízio de Royes Mello 님이
작성:
>
>
> On Sat, Mar 19, 2022 at 1:18 PM Dong Wook Lee wrote:
> >
> > > Well, my guess is that you basically just care about being able to
> > > detect if there is free space in the map or not, which goes down to
> > > detecting if pg_freespace(
On Sat, Mar 19, 2022 at 1:18 PM Dong Wook Lee wrote:
>
> > Well, my guess is that you basically just care about being able to
> > detect if there is free space in the map or not, which goes down to
> > detecting if pg_freespace() returns 0 or a number strictly higher than
> > 0, so wouldn't it be
> Well, my guess is that you basically just care about being able to
> detect if there is free space in the map or not, which goes down to
> detecting if pg_freespace() returns 0 or a number strictly higher than
> 0, so wouldn't it be enough to stick some > 0 in your test queries?
I edited the pre
2022년 3월 11일 (금) 오후 2:51, Michael Paquier 님이 작성:
>
> On Wed, Mar 09, 2022 at 08:13:15PM +0900, Dong Wook Lee wrote:
> > I agree with you, but I have no good idea how to deal with it.
>
> Well, my guess is that you basically just care about being able to
> detect if there is free space in the map or
On Wed, Mar 09, 2022 at 08:13:15PM +0900, Dong Wook Lee wrote:
> I agree with you, but I have no good idea how to deal with it.
Well, my guess is that you basically just care about being able to
detect if there is free space in the map or not, which goes down to
detecting if pg_freespace() returns
2022년 3월 9일 (수) 오전 1:19, Tom Lane 님이 작성:
> Dong Wook Lee writes:
> > [ 0001_add_test_pg_fsm.patch ]
>
> I think having some coverage here would be great, but I'm concerned that
> this patch doesn't look very portable. Aren't the numbers liable to
> change on 32-bit machines, in particular?
>
>
Dong Wook Lee writes:
> [ 0001_add_test_pg_fsm.patch ]
I think having some coverage here would be great, but I'm concerned that
this patch doesn't look very portable. Aren't the numbers liable to
change on 32-bit machines, in particular?
regards, tom lane
That's right, so I attached the correct file again.
2022년 3월 8일 (화) 오후 11:45, Justin Pryzby 님이 작성:
> On Tue, Mar 08, 2022 at 11:39:08PM +0900, Dong Wook Lee wrote:
> > Hi,
> > I just added some tests for the pg_freespacemap extension because the
> test
> > coverage was 0 percent.
> > But I don't
On Tue, Mar 08, 2022 at 11:39:08PM +0900, Dong Wook Lee wrote:
> Hi,
> I just added some tests for the pg_freespacemap extension because the test
> coverage was 0 percent.
> But I don't know if I did it correctly.
The patch only touches doc/*.sgml.
I suppose you forgot to use "git add".
--
Justi
I'm sorry for attaching the wrong patch file.
2022년 3월 8일 (화) 오후 11:39, Dong Wook Lee 님이 작성:
> Hi,
> I just added some tests for the pg_freespacemap extension because the test
> coverage was 0 percent.
> But I don't know if I did it correctly.
>
> ---
> Regards
> Lee Dong Wook
>
0001_add_test_p
Hi,
I just added some tests for the pg_freespacemap extension because the test
coverage was 0 percent.
But I don't know if I did it correctly.
---
Regards
Lee Dong Wook
0001_add_link_fsm.patch
Description: Binary data
17 matches
Mail list logo
