Re: Add tap test for --extra-float-digits option

2020-06-13 Thread Michael Paquier
On Sat, Jun 13, 2020 at 06:34:46PM +0900, Dong Wook Lee wrote: > First of all, thank you for merging my patch. > And I'm sorry, I should have been more careful about it. Next time I > will follow format. And there is something I will tell you We are all here to learn. It is good to begin with

Re: Add tap test for --extra-float-digits option

2020-06-13 Thread Dong Wook Lee
> That's more of an habit to look around, find similar patterns and the > check if these are covered. > > I have applied your patch, and you may want to be careful about a > couple of things: > - Please avoid top-posting on the mailing lists: >

Re: Add tap test for --extra-float-digits option

2020-06-12 Thread Michael Paquier
On Fri, Jun 12, 2020 at 06:15:36PM +0900, Dong Wook Lee wrote: > Oh, now I understand. and I added a test of --row-per-insert option. That's more of an habit to look around, find similar patterns and the check if these are covered. I have applied your patch, and you may want to be careful about

Re: Add tap test for --extra-float-digits option

2020-06-12 Thread Dong Wook Lee
Oh, now I understand. and I added a test of --row-per-insert option. I'd better find more options missing test 2020년 6월 12일 (금) 오후 4:04, Michael Paquier 님이 작성: > On Fri, Jun 12, 2020 at 02:30:35PM +0900, Dong Wook Lee wrote: > > Thank you for your response > > Do you mean to move it under the

Re: Add tap test for --extra-float-digits option

2020-06-11 Thread Michael Paquier
On Thu, Jun 11, 2020 at 02:25:37PM +0900, Dong Wook Lee wrote: > Hi hackers! I added tap test code for pg_dump --extra-float-digits option > because it hadn't tested it. There was no problem when writing test code > and running TAP tests. If we go down to that (there is a test for --compression),

Add tap test for --extra-float-digits option

2020-06-10 Thread Dong Wook Lee
Hi hackers! I added tap test code for pg_dump --extra-float-digits option because it hadn't tested it. There was no problem when writing test code and running TAP tests. 0001-Add-tap-test-for-extra-float-digits-option.patch Description: Binary data