Re: Add test module for Table Access Method

2024-01-16 Thread Mats Kindahl
On Tue, Jan 16, 2024 at 6:15 AM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier > wrote: > > > > Hmm. I'd rather have it do something useful in terms of test coverage > > rather than being just an empty skull. > > > > How

Re: Add test module for Table Access Method

2024-01-16 Thread Mats Kindahl
Hi all, On Tue, Jan 16, 2024 at 10:40 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi, > > > > I think a test module for a table AM will really help developers. Just > > > to add to the above list - how about the table AM implementing a > > > simple in-memory (columnar if

Re: Add test module for Table Access Method

2024-01-16 Thread Aleksander Alekseev
Hi, > > I think a test module for a table AM will really help developers. Just > > to add to the above list - how about the table AM implementing a > > simple in-memory (columnar if possible) database storing tables > > in-memory and subsequently providing readers with the access to the > >

Re: Add test module for Table Access Method

2024-01-15 Thread Japin Li
On Tue, 16 Jan 2024 at 13:15, Bharath Rupireddy wrote: > On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier wrote: >> >> Hmm. I'd rather have it do something useful in terms of test coverage >> rather than being just an empty skull. >> >> How about adding the same kind of coverage as

Re: Add test module for Table Access Method

2024-01-15 Thread Bharath Rupireddy
On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier wrote: > > Hmm. I'd rather have it do something useful in terms of test coverage > rather than being just an empty skull. > > How about adding the same kind of coverage as dummy_index_am with a > couple of reloptions then? That can serve as a

Re: Add test module for Table Access Method

2024-01-15 Thread Michael Paquier
On Mon, Jan 15, 2024 at 03:40:30PM +0100, Jelte Fennema-Nio wrote: > On Mon, 15 Jan 2024 at 14:26, Aleksander Alekseev > wrote: >> To be fair, Postgres uses TAM internally, so there is at least one >> complete and up-to-date real-life example. > > Sure, but that one is quite hard to follow if

Re: Add test module for Table Access Method

2024-01-15 Thread Jelte Fennema-Nio
On Mon, 15 Jan 2024 at 14:26, Aleksander Alekseev wrote: > To be fair, Postgres uses TAM internally, so there is at least one > complete and up-to-date real-life example. Sure, but that one is quite hard to follow if you don't already know lots of details of the heap storage. At least for me,

Re: Add test module for Table Access Method

2024-01-15 Thread Aleksander Alekseev
Hi, > When trying to implement a table access method in the past I remember > very well that I was having a really hard time finding an example of > one. To be fair, Postgres uses TAM internally, so there is at least one complete and up-to-date real-life example. Learning curve for TAMs is

Re: Add test module for Table Access Method

2024-01-15 Thread Jelte Fennema-Nio
On Thu, 28 Sept 2023 at 03:08, Michael Paquier wrote: > dummy_index_am has included from the start additional coverage for the > various internal add_*_reloption routines, that were never covered in > the core tree. Except if I am missing something, I am not seeing some > of the extra usefulness

Re: Add test module for Table Access Method

2024-01-14 Thread vignesh C
On Thu, 28 Sept 2023 at 10:23, Michael Paquier wrote: > > On Sat, Jun 03, 2023 at 07:42:36PM -0400, Fabrízio de Royes Mello wrote: > > So in order to improve things a bit in this area I'm proposing to add a > > test module for Table Access Method similar what we already have fo

Re: Add test module for Table Access Method

2023-09-27 Thread Michael Paquier
On Sat, Jun 03, 2023 at 07:42:36PM -0400, Fabrízio de Royes Mello wrote: > So in order to improve things a bit in this area I'm proposing to add a > test module for Table Access Method similar what we already have for Index > Access Method. > > This code is based on the "black

Re: Add test module for Table Access Method

2023-09-26 Thread Fabrízio de Royes Mello
out Table Access Method one missing item pointed out is that currently we lack documentation and examples of TAM. > > > > So in order to improve things a bit in this area I'm proposing to add a test module for Table Access Method similar what we already have for Index Access Method.

Re: Add test module for Table Access Method

2023-06-05 Thread Fabrízio de Royes Mello
in order to improve things a bit in this area I'm proposing to add a test module for Table Access Method similar what we already have for Index Access Method. > > This code is based on the "blackhole_am" implemented by Michael Paquier: https://github.com/michaelpq/pg_plugins/tree/main

Add test module for Table Access Method

2023-06-03 Thread Fabrízio de Royes Mello
Hi all, During the PGCon Unconference session about Table Access Method one missing item pointed out is that currently we lack documentation and examples of TAM. So in order to improve things a bit in this area I'm proposing to add a test module for Table Access Method similar what we already