Re: AioCtl Shared Memory size fix

2025-09-16 Thread Andres Freund
Hi, On 2025-09-16 15:50:20 +0900, Michael Paquier wrote: > On Mon, Sep 15, 2025 at 02:06:03PM +0200, Matthias van de Meent wrote: > > Presumably this was `PgAioHandle io_handles[]` at some point, but now > > that it's a pointer it's a proper part of the struct's own size, and > > should be treated

Re: AioCtl Shared Memory size fix

2025-09-15 Thread Michael Paquier
On Mon, Sep 15, 2025 at 02:06:03PM +0200, Matthias van de Meent wrote: > Presumably this was `PgAioHandle io_handles[]` at some point, but now > that it's a pointer it's a proper part of the struct's own size, and > should be treated as such for memory accounting. I would bet on a FLEXIBLE_ARRAY_M

Re: AioCtl Shared Memory size fix

2025-09-15 Thread Matthias van de Meent
On Mon, 15 Sept 2025 at 13:33, Madhukar . wrote: > > Hi Folks, > > While reviewing AIO code, we found an issue with AioCtlShmemSize function. > The function was not accounting for io_handles which is used post shared > memory alloc in AioShmemInit. Good catch. Presumably this was `PgAioHandle

AioCtl Shared Memory size fix

2025-09-15 Thread Madhukar .
Hi Folks, While reviewing AIO code, we found an issue with AioCtlShmemSize function. The function was not accounting for io_handles which is used post shared memory alloc in AioShmemInit. Please find a patch to account for io_handles member of PgAioCtl. The patch uses sizeof(PgAioCtl) instead of