Re: Another dead configure test

2022-08-18 Thread Tom Lane
Andres Freund writes: > On 2022-08-18 13:00:28 -0400, Tom Lane wrote: >> I wondered about that, but we do need TCL_SHARED_BUILD in configure >> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it. >> We could remove the line in Makefile.global but I don't think that >> buys much, a

Re: Another dead configure test

2022-08-18 Thread Andres Freund
Hi, On 2022-08-18 13:00:28 -0400, Tom Lane wrote: > Andres Freund writes: > > Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD > > isn't used either afaics? > > I wondered about that, but we do need TCL_SHARED_BUILD in configure > itself, and the PGAC_EVAL_TCLCONFIGSH

Re: Another dead configure test

2022-08-18 Thread Tom Lane
Andres Freund writes: > Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD > isn't used either afaics? I wondered about that, but we do need TCL_SHARED_BUILD in configure itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it. We could remove the line in Make

Re: Another dead configure test

2022-08-18 Thread Andres Freund
Hi, On 2022-08-18 11:04:03 -0400, Tom Lane wrote: > I happened to notice that configure extracts TCL_SHLIB_LD_LIBS > from tclConfig.sh, and puts the value into Makefile.global, > but then we never use it anywhere. AFAICT the only use went > away in cd75f94da, in 2003. I propose the attached. Lo

Another dead configure test

2022-08-18 Thread Tom Lane
I happened to notice that configure extracts TCL_SHLIB_LD_LIBS from tclConfig.sh, and puts the value into Makefile.global, but then we never use it anywhere. AFAICT the only use went away in cd75f94da, in 2003. I propose the attached. regards, tom lane diff --git a/confi