Re: Assign TupleTableSlot->tts_tableOid duplicated in tale AM.

2022-09-29 Thread Wenchao Zhang
Firstly, thank you for your reply. Yeah, I think maybe just assigning tts_tableOid of TTS only once during scanning the same table may be better. That really needs to be thinked over. Regards, Wenchao Peter Geoghegan 于2022年9月28日周三 10:47写道: > On Tue, Sep 20, 2022 at 11:51 PM Wenchao Zhang > wro

Re: Assign TupleTableSlot->tts_tableOid duplicated in tale AM.

2022-09-27 Thread Peter Geoghegan
On Tue, Sep 20, 2022 at 11:51 PM Wenchao Zhang wrote: > We can get the two assigned values are same by reading codes. Maybe we should > remove one? > > What's more, we find that maybe we assign slot->tts_tableOid in outer > interface like table_scan_getnextslot may be better and more friendly wh

Assign TupleTableSlot->tts_tableOid duplicated in tale AM.

2022-09-20 Thread Wenchao Zhang
Hi hackers, Recently, we discover that the field of tts_tableOid of TupleTableSlot is assigned duplicated in table AM's interface which is not necessary. For example, in table_scan_getnextslot, ``` static inline bool table_scan_getnextslot(TableScanDesc sscan, ScanDirection direction, TupleTableS