Re: Avoid possible memory leak (src/common/rmtree.c)

2023-07-31 Thread Michael Paquier
On Mon, Jul 31, 2023 at 08:10:55PM -0300, Ranier Vilela wrote: > Thanks for the commit, Michael. Sorry for the lack of update here. For the sake of the archives, this is f1e9f6b. -- Michael signature.asc Description: PGP signature

Re: Avoid possible memory leak (src/common/rmtree.c)

2023-07-31 Thread Ranier Vilela
Em sex, 28 de jul de 2023 11:54 PM, Michael Paquier escreveu: > On Tue, Jul 25, 2023 at 04:45:22PM +0200, Daniel Gustafsson wrote: > > Skimming the tree there doesn't seem to be any callers which aren't > exiting or > > ereporting on failure so the real-world impact seems low. That being > said,

Re: Avoid possible memory leak (src/common/rmtree.c)

2023-07-28 Thread Michael Paquier
On Tue, Jul 25, 2023 at 04:45:22PM +0200, Daniel Gustafsson wrote: > Skimming the tree there doesn't seem to be any callers which aren't exiting or > ereporting on failure so the real-world impact seems low. That being said, > silencing static analyzers could be reason enough to delay allocation.

Re: Avoid possible memory leak (src/common/rmtree.c)

2023-07-25 Thread Daniel Gustafsson
> On 25 Jul 2023, at 16:31, Ranier Vilela wrote: > rmtree function can leak 64 bytes per call, > when it can't open a directory. Skimming the tree there doesn't seem to be any callers which aren't exiting or ereporting on failure so the real-world impact seems low. That being said, silencing s

Avoid possible memory leak (src/common/rmtree.c)

2023-07-25 Thread Ranier Vilela
Hi, Per Coverity. rmtree function can leak 64 bytes per call, when it can't open a directory. patch attached. best regards, Ranier Vilela 0003-Avoid-possible-memory-leak-64-bytes-per-rmtree-call-.patch Description: Binary data