Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-10 Thread Andres Freund
On 2019-03-10 13:29:06 -0300, Alvaro Herrera wrote: > Hello > > On 2019-Mar-08, Andres Freund wrote: > > > > diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c > > > index e962ae7e913..1de8da59361 100644 > > > --- a/src/bin/pg_dump/pg_dump.c > > > +++ b/src/bin/pg_dump/pg_dump.c >

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-10 Thread Alvaro Herrera
Hello On 2019-Mar-08, Andres Freund wrote: > > diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c > > index e962ae7e913..1de8da59361 100644 > > --- a/src/bin/pg_dump/pg_dump.c > > +++ b/src/bin/pg_dump/pg_dump.c > > @@ -4359,9 +4359,9 @@ binary_upgrade_set_type_oids_by_rel_oid(Arc

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-08 Thread Andres Freund
Hi, On 2019-03-08 20:18:27 -0300, Alvaro Herrera wrote: > On 2019-Mar-07, Robert Haas wrote: > > > On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > > > I think we probably should have pg_dump suppress emitting information > > > about the toast table of partitioned tables? > > > > +1. That

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-07, Robert Haas wrote: > On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > > I think we probably should have pg_dump suppress emitting information > > about the toast table of partitioned tables? > > +1. That seems like the right fix. This patch fixes the upgrade problem for me

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-07 Thread Robert Haas
On Thu, Mar 7, 2019 at 1:17 PM Andres Freund wrote: > > > While I'm not hugely bothered by binary upgrade mode creating > > > inconsistent states - there's plenty of ways to crash the server that > > > way - it probably also would be a good idea to have heap_create() > > > elog(ERROR) when accessm

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-07 Thread Alvaro Herrera
On 2019-Mar-07, Andres Freund wrote: > Hi, > > On 2019-03-07 13:08:35 -0500, Robert Haas wrote: > > On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > > > I think we probably should have pg_dump suppress emitting information > > > about the toast table of partitioned tables? > > > > +1. That

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-07 Thread Andres Freund
Hi, On 2019-03-07 13:08:35 -0500, Robert Haas wrote: > On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > > I think we probably should have pg_dump suppress emitting information > > about the toast table of partitioned tables? > > +1. That seems like the right fix. Cool. Alvaro, Kyatoro, Mic

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-07 Thread Robert Haas
On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > I think we probably should have pg_dump suppress emitting information > about the toast table of partitioned tables? +1. That seems like the right fix. > While I'm not hugely bothered by binary upgrade mode creating > inconsistent states - t

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-06 Thread Andres Freund
Hi, On 2019-03-06 16:46:07 -0500, Andrew Dunstan wrote: > > On 3/6/19 3:41 PM, Andres Freund wrote: > > Hi, > > > > After my tableam patch Andrew's buildfarm animal started failing in the > > cross-version upgrades: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-03-06%2

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-06 Thread Andrew Dunstan
On 3/6/19 3:41 PM, Andres Freund wrote: > Hi, > > After my tableam patch Andrew's buildfarm animal started failing in the > cross-version upgrades: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-03-06%2019%3A32%3A24 Incidentally, I just fixed a bug that was preventing t

Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-06 Thread Andres Freund
Hi, After my tableam patch Andrew's buildfarm animal started failing in the cross-version upgrades: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-03-06%2019%3A32%3A24 But I actually don't think that't really fault of the tableam patch. The reason for the assertion is that