Re: Bracket, brace, parenthesis

2021-05-30 Thread Kyotaro Horiguchi
At Mon, 31 May 2021 11:36:23 +0900, Michael Paquier wrote in > On Fri, May 28, 2021 at 03:25:40PM +0900, Kyotaro Horiguchi wrote: > > Mmm. Thanks. So the test doesn't a check for the case of trailing > > garbage. Looking the discussion about trailing garbage of integer > > values, we might need

Re: Bracket, brace, parenthesis

2021-05-30 Thread Michael Paquier
On Fri, May 28, 2021 at 03:25:40PM +0900, Kyotaro Horiguchi wrote: > Mmm. Thanks. So the test doesn't a check for the case of trailing > garbage. Looking the discussion about trailing garbage of integer > values, we might need one for the case. > > The atached second file adds a test for trailing

Re: Bracket, brace, parenthesis

2021-05-27 Thread Kyotaro Horiguchi
At Thu, 27 May 2021 21:08:46 +0900, Michael Paquier wrote in > On Thu, May 27, 2021 at 03:20:10PM +0900, Kyotaro Horiguchi wrote: > > At Fri, 14 May 2021 10:04:57 -0400, Tom Lane wrote in > >> +1. I tend to write "square bracket" or "curly brace" when I want to > >> be extra clear, but I thin

Re: Bracket, brace, parenthesis

2021-05-27 Thread Michael Paquier
On Thu, May 27, 2021 at 03:20:10PM +0900, Kyotaro Horiguchi wrote: > At Fri, 14 May 2021 10:04:57 -0400, Tom Lane wrote in >> +1. I tend to write "square bracket" or "curly brace" when I want to >> be extra clear, but I think the bare terms are widely understood to >> have those meanings. > > T

Re: Bracket, brace, parenthesis

2021-05-26 Thread Kyotaro Horiguchi
At Fri, 14 May 2021 10:04:57 -0400, Tom Lane wrote in > Kyotaro Horiguchi writes: > > I'm not sure how much we (or people) are strcit on the distinction > > between the $SUBJECT, isn't '{' a brace generally? > > +1. I tend to write "square bracket" or "curly brace" when I want to > be extra cl

Re: Bracket, brace, parenthesis

2021-05-14 Thread Tom Lane
Kyotaro Horiguchi writes: > I'm not sure how much we (or people) are strcit on the distinction > between the $SUBJECT, isn't '{' a brace generally? +1. I tend to write "square bracket" or "curly brace" when I want to be extra clear, but I think the bare terms are widely understood to have those

Bracket, brace, parenthesis

2021-05-13 Thread Kyotaro Horiguchi
I found the following code in multirangetypes.c > if (*ptr == '{') > ptr++; > else > ereport(ERROR, > (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION), >errmsg("malformed multirange literal: \"%s\"",