Re: BufFileSize() doesn't work on a "shared" BufFiles

On 30/04/18 22:00, Peter Geoghegan wrote: On Mon, Apr 30, 2018 at 10:18 AM, Heikki Linnakangas wrote: Perhaps that would be OK, if it was properly commented. But it's not actually hard to make BufFileSize() work on shared files, too, so I think we should do that. I agree

Re: BufFileSize() doesn't work on a "shared" BufFiles

On Mon, Apr 30, 2018 at 10:18 AM, Heikki Linnakangas wrote: > Perhaps that would be OK, if it was properly commented. But it's not > actually hard to make BufFileSize() work on shared files, too, so I think we > should do that. I agree that this could use a comment, but I don't

BufFileSize() doesn't work on a "shared" BufFiles

Hi, I've been noodling around the tuplesort/logtape code, reviewing the changes that were made in v11 to support parallel sorting, and also rebasing my older patch to replace the polyphase merge with a simple balanced merge. Looking at TapeShare: /* * The approach tuplesort.c takes to