Re: Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-06-07 Thread Ryo Matsumura (Fujitsu)
# I'm sorry for my late response. I confirmed that the error of regression is caused by my code inserting setlocale() into ecpglib of local branch. No other tests occur error in non-C locale. The following is about other topics. 1. About regression test We should test the followings: - PGTYPE

Re: Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-05-10 Thread Ryo Matsumura (Fujitsu)
Hi Tom, Thank you for comment. >> At current implementation, PGTYPEStimestamp_from_asc returns -1. > It looks to me like it returns 0 ("noresult"). Where are you seeing -1? I took a mistake. Sorry. PGTYPEStimestamp_from_asc returns 0(noresult). PGTYPEStimestamp_fmt_asc given 'noresult' returns -

Re: Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-05-10 Thread Tom Lane
"Ryo Matsumura (Fujitsu)" writes: >> But how come we haven't noticed that >> before? Have you added a setlocale() call somewhere? > I didn't notice to this point. > I added setlocale() to ECPG in my local branch. > I will test again after removing it. > It looks to me like existing ECPG code doe

Re: Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-05-09 Thread Tom Lane
"Ryo Matsumura (Fujitsu)" writes: > It is indefinite what PGTYPEStimestamp_from_asc() returns in error. > The following is written in document(36.6.8. Special Constants of pgtypeslib): > A value of type timestamp representing an invalid time stamp. > This is returned by the function PGTYPEStim

Bug: PGTYPEStimestamp_from_asc() in ECPG pgtypelib

2024-05-09 Thread Ryo Matsumura (Fujitsu)
Hi hackers, I detected two problems about ECPG. I show my opinion. Please comment. If it's correct, I will prepare a patch. Thank you. 1. It is indefinite what PGTYPEStimestamp_from_asc() returns in error. The following is written in document(36.6.8. Special Constants of pgtypeslib): A value of