Re: Build versionless .so for Android

2024-01-23 Thread Peter Eisentraut
On 19.01.24 18:12, Matthias Kuhn wrote: Thanks, This patch brought it further and indeed, the resulting libpq.so file is unversioned when built for Android while it's versioned when built for linux. Ok, I have committed all of this now: - Fix for correct order of host_system and portname as

Re: Build versionless .so for Android

2024-01-19 Thread Matthias Kuhn
Thanks, This patch brought it further and indeed, the resulting libpq.so file is unversioned when built for Android while it's versioned when built for linux. Matthias On Fri, Jan 19, 2024 at 3:00 PM Peter Eisentraut wrote: > On 19.01.24 11:08, Matthias Kuhn wrote: > > When trying to build wit

Re: Build versionless .so for Android

2024-01-19 Thread Peter Eisentraut
On 19.01.24 11:08, Matthias Kuhn wrote: When trying to build with meson, including the patch which was provided by Andres Freud (thanks), I am currently stuck with the following error: Configuring pg_config_ext.h using configuration ../src/tgresql-16-685bc9fc97.clean/src/include/meson.build:12

Re: Build versionless .so for Android

2024-01-19 Thread Matthias Kuhn
Hi On Thu, Jan 18, 2024 at 9:27 AM Peter Eisentraut wrote: > On 14.01.24 12:37, Matthias Kuhn wrote: > > What I try to do is packaging an app with androiddeployqt which fails > > with an error: > > > > The bundled library lib/libpq.so.5 doesn't end with .so. Android only > > supports versionless

Re: Build versionless .so for Android

2024-01-18 Thread Peter Eisentraut
On 14.01.24 12:37, Matthias Kuhn wrote: What I try to do is packaging an app with androiddeployqt which fails with an error: The bundled library lib/libpq.so.5 doesn't end with .so. Android only supports versionless libraries ending with the .so suffix. This error was introduced in response

Re: Build versionless .so for Android

2024-01-14 Thread Matthias Kuhn
What I try to do is packaging an app with androiddeployqt which fails with an error: The bundled library lib/libpq.so.5 doesn't end with .so. Android only supports versionless libraries ending with the .so suffix. This error was introduced in response to this issue which contains hints about the

Re: Build versionless .so for Android

2024-01-05 Thread Andres Freund
Hi, On 2024-01-05 15:57:23 +0100, Peter Eisentraut wrote: > On 05.01.24 01:00, Matthias Kuhn wrote: > > Attached a patch with a (hopefully) better wording of the comment. > > > > I have unsuccessfully tried to find an official source for this policy. > > So for reference some discussions about th

Re: Build versionless .so for Android

2024-01-05 Thread Andres Freund
Hi, On 2024-01-05 16:00:01 +0100, Peter Eisentraut wrote: > On 01.01.24 06:25, Matthias Kuhn wrote: > > It looks like meson does not currently support building for android, the > > following output is what I get (but I have actually no experience with > > meson): > > > >     meson.build:320:2: E

Re: Build versionless .so for Android

2024-01-05 Thread Peter Eisentraut
On 01.01.24 06:25, Matthias Kuhn wrote: It looks like meson does not currently support building for android, the following output is what I get (but I have actually no experience with meson):     meson.build:320:2: ERROR: Problem encountered: unknown host system: android FWIW, the meson so

Re: Build versionless .so for Android

2024-01-05 Thread Peter Eisentraut
On 05.01.24 01:00, Matthias Kuhn wrote: Attached a patch with a (hopefully) better wording of the comment. I have unsuccessfully tried to find an official source for this policy. So for reference some discussions about the topic: - https://stackoverflow.com/questions/11491065/linking-with-vers

Re: Build versionless .so for Android

2024-01-05 Thread Robert Haas
On Thu, Jan 4, 2024 at 7:00 PM Matthias Kuhn wrote: > Attached a patch with a (hopefully) better wording of the comment. > > I have unsuccessfully tried to find an official source for this policy. > So for reference some discussions about the topic: > > - > https://stackoverflow.com/questions/114

Re: Build versionless .so for Android

2024-01-04 Thread Matthias Kuhn
Hi, Attached a patch with a (hopefully) better wording of the comment. I have unsuccessfully tried to find an official source for this policy. So for reference some discussions about the topic: - https://stackoverflow.com/questions/11491065/linking-with-versioned-shared-library-in-android-ndk -

Re: Build versionless .so for Android

2024-01-02 Thread Robert Haas
On Sun, Dec 31, 2023 at 1:24 AM Michael Paquier wrote: > FWIW, I have mixed feelings about patching the code to treat > android-linux as an exception while changing nothing in the > documentation to explain why this is required. A custom patch may > serve you better here, and note that you did no

Re: Build versionless .so for Android

2023-12-31 Thread Matthias Kuhn
Thanks for all the comments and help. I have added the patch to the January CF. It looks like meson does not currently support building for android, the following output is what I get (but I have actually no experience with meson): meson.build:320:2: ERROR: Problem encountered: unknown host

Re: Build versionless .so for Android

2023-12-31 Thread Joe Conway
On 12/31/23 01:24, Michael Paquier wrote: On Sun, Dec 31, 2023 at 06:08:04AM +0100, Matthias Kuhn wrote: I was wondering if there are a) any comments on the approach and if I should be handed in for a commitfest (currently waiting for the cooldown period after account activation, I am not sure h

Re: Build versionless .so for Android

2023-12-30 Thread Michael Paquier
On Sun, Dec 31, 2023 at 06:08:04AM +0100, Matthias Kuhn wrote: > In order to ship libpq on Android, it needs to be built without a version > suffix on the .so file. > The attached patch will make sure that no version is added when built for > Android. FWIW, I have mixed feelings about patching the

Re: Build versionless .so for Android

2023-12-30 Thread Tom Lane
Matthias Kuhn writes: > In order to ship libpq on Android, it needs to be built without a version > suffix on the .so file. > The attached patch will make sure that no version is added when built for > Android. This ... seems incredibly brain-dead. Does Android really not cope with version-to-ve

Build versionless .so for Android

2023-12-30 Thread Matthias Kuhn
Hi, In order to ship libpq on Android, it needs to be built without a version suffix on the .so file. The attached patch will make sure that no version is added when built for Android. I was wondering if there are a) any comments on the approach and if I should be handed in for a commitfest (curre