Re: Building with meson on NixOS/nixpkgs

2024-08-17 Thread Wolfgang Walther
Tristan Partin: On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote: commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce Author: Heikki Linnakangas Date:   2024-07-27 13:53:11 +0300     Fallback to clang in PATH with meson [..] I think this is a bad change unfortunately - this way clang and l

Re: Building with meson on NixOS/nixpkgs

2024-08-17 Thread Wolfgang Walther
Tristan Partin: On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote: [..] commit a00fae9d43e5adabc56e64a4df6d332062666501 Author: Heikki Linnakangas Date:   2024-07-27 13:53:08 +0300     Fallback to uuid for ossp-uuid with meson [..] I think this is a redundant change with commit 2416fdb

Re: Building with meson on NixOS/nixpkgs

2024-08-09 Thread Tristan Partin
On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote: Hi, commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce Author: Heikki Linnakangas Date: 2024-07-27 13:53:11 +0300 Fallback to clang in PATH with meson Some distributions put clang into a different path than the llvm binary p

Re: Building with meson on NixOS/nixpkgs

2024-08-09 Thread Andres Freund
Hi, commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce Author: Heikki Linnakangas Date: 2024-07-27 13:53:11 +0300 Fallback to clang in PATH with meson Some distributions put clang into a different path than the llvm binary path. For example, this is the case on NixOS / nixpkgs,

Re: Building with meson on NixOS/nixpkgs

2024-07-27 Thread Heikki Linnakangas
On 26/07/2024 23:01, Tristan Partin wrote: Heikki asked me to take a look at this patchset for the commitfest. Looks good to me. Heikki, just be careful rebasing the first patch. You need to make sure the newly set `required: false` gets carried forward. Committed and backpatched to v16 and v1

Re: Building with meson on NixOS/nixpkgs

2024-07-26 Thread Tristan Partin
Heikki asked me to take a look at this patchset for the commitfest. Looks good to me. Heikki, just be careful rebasing the first patch. You need to make sure the newly set `required: false` gets carried forward. -- Tristan Partin Neon (https://neon.tech)

Re: Building with meson on NixOS/nixpkgs

2024-04-17 Thread walther
Peter Eisentraut: On 29.03.24 19:47, walt...@technowledgy.de wrote: > -    uuid = dependency('ossp-uuid', required: true) > +    # upstream is called "uuid", but many distros change this to "ossp-uuid" > +    uuid = dependency('ossp-uuid', 'uuid', required: true) How would this behave if yo

Re: Building with meson on NixOS/nixpkgs

2024-04-17 Thread Peter Eisentraut
On 29.03.24 19:47, walt...@technowledgy.de wrote: > -uuid = dependency('ossp-uuid', required: true) > +# upstream is called "uuid", but many distros change this to "ossp-uuid" > +uuid = dependency('ossp-uuid', 'uuid', required: true) How would this behave if you have only uuid.pc fr

Re: Building with meson on NixOS/nixpkgs

2024-04-01 Thread Nazir Bilal Yavuz
Hi, >From your prior reply: On Thu, 21 Mar 2024 at 23:44, Wolfgang Walther wrote: > > Nazir Bilal Yavuz: > > 0001 & 0002: Adding code comments to explain why they have fallback > > could be nice. > > 0003: Looks good to me. > > Added some comments in the attached. Comments look good, thanks. O

Re: Building with meson on NixOS/nixpkgs

2024-03-29 Thread walther
Wolfgang Walther: To build on NixOS/nixpkgs I came up with a few small patches to meson.build. All of this works fine with Autoconf/Make already. In v3, I added another small patch for meson, this one about proper handling of -Dlibedit_preferred when used together with -Dreadline=enabled. Be

Re: Building with meson on NixOS/nixpkgs

2024-03-21 Thread Wolfgang Walther
Nazir Bilal Yavuz: 0001 & 0002: Adding code comments to explain why they have fallback could be nice. 0003: Looks good to me. Added some comments in the attached. Best, WolfgangFrom 2d271aafd96a0ea21710a06ac5236e47217c36d1 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Sat, 2 Mar 2024

Re: Building with meson on NixOS/nixpkgs

2024-03-18 Thread Alvaro Herrera
On 2024-Mar-16, Wolfgang Walther wrote: > The upstream name for the ossp-uuid package / pkg-config file is "uuid". Many > distributions change this to be "ossp-uuid" to not conflict with e2fsprogs. I can confirm that this is true for Debian, at least; the packaging rules have this in override_dh_

Re: Building with meson on NixOS/nixpkgs

2024-03-18 Thread Nazir Bilal Yavuz
Hi, Thank you for the patches! On Sat, 16 Mar 2024 at 14:48, Wolfgang Walther wrote: > > To build on NixOS/nixpkgs I came up with a few small patches to > meson.build. All of this works fine with Autoconf/Make already. I do not have NixOS but I confirm that patches cleanly apply to master and d

Building with meson on NixOS/nixpkgs

2024-03-16 Thread Wolfgang Walther
To build on NixOS/nixpkgs I came up with a few small patches to meson.build. All of this works fine with Autoconf/Make already.From 24ae72b9b0adc578c6729eff59c9038e6b4ac517 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Sat, 2 Mar 2024 17:18:38 +0100 Subject: [PATCH 1/3] Fallback to uuid f