Re: CREATE STATISTICS documentation bug

2019-07-06 Thread Peter Eisentraut
On 2019-06-14 23:04, Alvaro Herrera wrote: > On 2019-Jun-14, Tom Lane wrote: > >> Alvaro Herrera writes: > >>> Proposal: each program declares at startup whether it wants the program >>> name prefix or not. >> >> Well, to clarify: I think it's reasonable to include "psql: " if the >> message is

Re: CREATE STATISTICS documentation bug

2019-06-17 Thread Robert Haas
On Sat, Jun 15, 2019 at 7:22 PM Tomas Vondra wrote: > I've pushed a fix for the docs issue. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: CREATE STATISTICS documentation bug

2019-06-15 Thread Tomas Vondra
On Fri, Jun 14, 2019 at 03:23:29PM -0400, Robert Haas wrote: https://www.postgresql.org/docs/12/sql-createstatistics.html contains this example command: CREATE STATISTICS s2 (mcv) ON (a, b) FROM t2; But that produces: psql: ERROR: only simple column references are allowed in CREATE STATISTICS

Re: CREATE STATISTICS documentation bug

2019-06-14 Thread Alvaro Herrera
On 2019-Jun-14, Tom Lane wrote: > Alvaro Herrera writes: > > Proposal: each program declares at startup whether it wants the program > > name prefix or not. > > Well, to clarify: I think it's reasonable to include "psql: " if the > message is originating in psql. So I don't think your idea qui

Re: CREATE STATISTICS documentation bug

2019-06-14 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Jun-14, Tom Lane wrote: >> Robert Haas writes: >>> P.S. I think the fact that we print "psql: " before the ERROR here is >>> useless clutter. We didn't do that in v11 and prior and I think we >>> should kill it with fire. >> Agreed, particularly seeing that the

Re: CREATE STATISTICS documentation bug

2019-06-14 Thread Alvaro Herrera
On 2019-Jun-14, Tom Lane wrote: > Robert Haas writes: > > P.S. I think the fact that we print "psql: " before the ERROR here is > > useless clutter. We didn't do that in v11 and prior and I think we > > should kill it with fire. > > Agreed, particularly seeing that the error is not originating

Re: CREATE STATISTICS documentation bug

2019-06-14 Thread Tom Lane
Robert Haas writes: > P.S. I think the fact that we print "psql: " before the ERROR here is > useless clutter. We didn't do that in v11 and prior and I think we > should kill it with fire. Agreed, particularly seeing that the error is not originating with psql; it's just passing it on.

CREATE STATISTICS documentation bug

2019-06-14 Thread Robert Haas
https://www.postgresql.org/docs/12/sql-createstatistics.html contains this example command: CREATE STATISTICS s2 (mcv) ON (a, b) FROM t2; But that produces: psql: ERROR: only simple column references are allowed in CREATE STATISTICS I think the parentheses around (a, b) just need to be removed