Re: Can we remove the #fdef UNUSED code from nbtxlog.c

2018-12-13 Thread Michael Paquier
On Thu, Dec 13, 2018 at 03:28:15PM -0800, Andres Freund wrote: > nbtxlog.c has a fairly large section of code commented out with #ifdef > UNUSED. With a node justifying that with: > > +* This section of code is thought to be no longer needed, after > +* analysis of the calling paths. It is

Can we remove the #fdef UNUSED code from nbtxlog.c

2018-12-13 Thread Andres Freund
Hi, nbtxlog.c has a fairly large section of code commented out with #ifdef UNUSED. With a node justifying that with: +* This section of code is thought to be no longer needed, after +* analysis of the calling paths. It is retained to allow the code +* to be reinstated if a flaw is rev