Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-04-07 Thread Nazir Bilal Yavuz
Hi Andrey, On Sun, 7 Apr 2024 at 08:29, Andrey M. Borodin wrote: > > > > > On 15 Mar 2024, at 17:12, Nazir Bilal Yavuz wrote: > > > > I did not have the time to check other things you mentioned but I > > tested the read performance. The table size is 5.5GB, I did 20 runs in > > total. > > Hi Naz

Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-04-06 Thread Andrey M. Borodin
> On 15 Mar 2024, at 17:12, Nazir Bilal Yavuz wrote: > > I did not have the time to check other things you mentioned but I > tested the read performance. The table size is 5.5GB, I did 20 runs in > total. Hi Nazir! Do you plan to review anything else? Or do you think it worth to look at by

Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-03-15 Thread Nazir Bilal Yavuz
Hi, On Thu, 7 Mar 2024 at 15:26, Cédric Villemain wrote: > > On 07/03/2024 12:19, Nazir Bilal Yavuz wrote: > > > > I did not test read performance but I am planning to do that soon. I did not have the time to check other things you mentioned but I tested the read performance. The table size is 5

Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-03-07 Thread Cédric Villemain
Hi Nazir, On 07/03/2024 12:19, Nazir Bilal Yavuz wrote: On Wed, 6 Mar 2024 at 18:23, Cédric Villemain wrote: The behavior is 100% OK, and in fact it might a bad idea to prefetch block by block as the result is just to put more pressure on a system if it is already under pressure. Though there

Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-03-07 Thread Nazir Bilal Yavuz
Hi, On Wed, 6 Mar 2024 at 18:23, Cédric Villemain wrote: > > Hi Nazir, > > > thank you for your review. I comment below. > > > On 05/03/2024 12:07, Nazir Bilal Yavuz wrote: > >> 2. The second one does implement smgrprefetch with range and loops by > >> default per segment to still have a check fo

Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-03-06 Thread Cédric Villemain
Hi Nazir, thank you for your review. I comment below. On 05/03/2024 12:07, Nazir Bilal Yavuz wrote: 2. The second one does implement smgrprefetch with range and loops by default per segment to still have a check for interrupts. It looks good codewise but RELSEG_SIZE is too big to prefetch. M

Re: Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-03-05 Thread Nazir Bilal Yavuz
Hi, Thanks for working on this! The patches are cleanly applied on top of the current master and all tests are passed. On Thu, 4 Jan 2024 at 02:23, Cedric Villemain wrote: > > Hi, > > I wonder what you think of making pg_prewarm use recent addition on > smgrprefetch and readv ? > > > In order t

Change prefetch and read strategies to use range in pg_prewarm ... and raise a question about posix_fadvise WILLNEED

2024-01-03 Thread Cedric Villemain
Hi, I wonder what you think of making pg_prewarm use recent addition on smgrprefetch and readv ? In order to try, I did it anyway in the attached patches. They contain no doc update, but I will proceed if it is of interest. In summary: 1. The first one adds a new check on parameters (chec