Re: Clean up MinGW def file generation

2019-10-22 Thread Peter Eisentraut
On 2019-10-21 00:07, Peter Eisentraut wrote: > On 2019-10-20 10:26, Peter Eisentraut wrote: >> On 2019-10-18 15:00, Tom Lane wrote: >>> Yeah, the comment that Peter complained about is mine. I believe the >>> desire to avoid depending on "sed" at build time was focused on our >>> old support for

Re: Clean up MinGW def file generation

2019-10-20 Thread Peter Eisentraut
On 2019-10-20 10:26, Peter Eisentraut wrote: > On 2019-10-18 15:00, Tom Lane wrote: >> Yeah, the comment that Peter complained about is mine. I believe the >> desire to avoid depending on "sed" at build time was focused on our >> old support for building libpq with Borland C (and not much else).

Re: Clean up MinGW def file generation

2019-10-20 Thread Peter Eisentraut
On 2019-10-18 15:00, Tom Lane wrote: > Yeah, the comment that Peter complained about is mine. I believe the > desire to avoid depending on "sed" at build time was focused on our > old support for building libpq with Borland C (and not much else). > Since this makefile infrastructure is now only

Re: Clean up MinGW def file generation

2019-10-18 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Oct-17, Michael Paquier wrote: >> On Tue, Oct 15, 2019 at 09:00:23AM +0200, Peter Eisentraut wrote: >>> I think we can clean this up and just have the regular ddl.def built >>> normally at build time if required. >>> Does anyone know more about this? > Well, yes,

Re: Clean up MinGW def file generation

2019-10-18 Thread Alvaro Herrera
On 2019-Oct-17, Michael Paquier wrote: > On Tue, Oct 15, 2019 at 09:00:23AM +0200, Peter Eisentraut wrote: > > I think we can clean this up and just have the regular ddl.def built > > normally at build time if required. > > > > Does anyone know more about this? > > This comes from here, but I

Re: Clean up MinGW def file generation

2019-10-17 Thread Michael Paquier
On Tue, Oct 15, 2019 at 09:00:23AM +0200, Peter Eisentraut wrote: > This doesn't make much sense (anymore?) since MinGW surely has sed and > MSVC doesn't use this (and has Perl). I think this is a leftover from > various ancient client-only ad-hoc Windows build provisions (those > win32.mak files

Clean up MinGW def file generation

2019-10-15 Thread Peter Eisentraut
http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 5cf449d76be516b207bb77b7802585f7612a776f Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 15 Oct 2019 08:48:35 +0200 Subject: [PATCH] Clean up MinGW def file genera