>
> Is there a test case covering this part of the code(I'm not sure if
> one exists in the regression test suite)?
> If no, can we add one?
>
I observed that the code areas this patch is trying to modify are
pretty much generic and are being called from many places.
The code basically handles
On Fri, Jul 3, 2020 at 1:32 PM Peter Eisentraut
wrote:
>
> On 2020-07-01 09:00, Amul Sul wrote:
> > Attached patch makes an adjustment to ipc.c code to be in the 80-column
> > window.
>
> I can see an argument that this makes the code a bit easier to read, but
> making code fit into 80 columns
On 2020-07-01 09:00, Amul Sul wrote:
Attached patch makes an adjustment to ipc.c code to be in the 80-column
window.
I can see an argument that this makes the code a bit easier to read, but
making code fit into 80 columns doesn't have to be a goal by itself.
--
Peter Eisentraut
> >
> > one comment: instead of having block variables onexit, in the while
> > loops in shmem_exit, can we have a single local variable defined at
> > the start of the shmem_exit function
> > and reuse them in the while loops? same comment for onexit block
> > variable in proc_exit_prepare()
On Wed, Jul 1, 2020 at 4:29 PM Bharath Rupireddy
wrote:
>
> changes look good to me.
Thanks for looking at the patch.
>
> one comment: instead of having block variables onexit, in the while
> loops in shmem_exit, can we have a single local variable defined at
> the start of the shmem_exit
changes look good to me.
one comment: instead of having block variables onexit, in the while
loops in shmem_exit, can we have a single local variable defined at
the start of the shmem_exit function
and reuse them in the while loops? same comment for onexit block
variable in proc_exit_prepare()
Hi,
Attached patch makes an adjustment to ipc.c code to be in the 80-column
window.
Regards,
Amul
0001-cleanup-adjust-code-in-80-column-window.patch
Description: Binary data
