Re: Comment in preptlist.c

2023-03-22 Thread Etsuro Fujita
On Wed, Mar 22, 2023 at 4:50 PM David Rowley wrote: > And now it just clicked with me why Tom left this. Sorry for stepping > on your toes here. No problem at all. Best regards, Etsuro Fujita

Re: Comment in preptlist.c

2023-03-22 Thread David Rowley
On Wed, 22 Mar 2023 at 20:40, Etsuro Fujita wrote: > Thanks for picking this up, David! Thanks for looking, Tom and Richard! And now it just clicked with me why Tom left this. Sorry for stepping on your toes here. David

Re: Comment in preptlist.c

2023-03-22 Thread Etsuro Fujita
On Wed, Mar 22, 2023 at 4:59 AM David Rowley wrote: > On Tue, 21 Mar 2023 at 22:41, Etsuro Fujita wrote: > > I think that “planner/rewriter” should be parser/rewriter. Attached > > is a patch for that. > > Pushed. Thanks for picking this up, David! Thanks for looking, Tom and Richard! Best

Re: Comment in preptlist.c

2023-03-21 Thread David Rowley
On Tue, 21 Mar 2023 at 22:41, Etsuro Fujita wrote: > I think that “planner/rewriter” should be parser/rewriter. Attached > is a patch for that. Pushed. David

Re: Comment in preptlist.c

2023-03-21 Thread Tom Lane
Etsuro Fujita writes: > While working on something else, I noticed $SUBJECT added by commit 86dc90056: > * For UPDATE and DELETE queries, the targetlist must also contain "junk" > * tlist entries needed to allow the executor to identify the rows to be > * updated or deleted; for example, the

Re: Comment in preptlist.c

2023-03-21 Thread Richard Guo
On Tue, Mar 21, 2023 at 5:41 PM Etsuro Fujita wrote: > While working on something else, I noticed $SUBJECT added by commit > 86dc90056: > > * For UPDATE and DELETE queries, the targetlist must also contain "junk" > * tlist entries needed to allow the executor to identify the rows to be > *

Comment in preptlist.c

2023-03-21 Thread Etsuro Fujita
While working on something else, I noticed $SUBJECT added by commit 86dc90056: * For UPDATE and DELETE queries, the targetlist must also contain "junk" * tlist entries needed to allow the executor to identify the rows to be * updated or deleted; for example, the ctid of a heap row. (The