Contributing with code

2017-12-27 Thread Antonio Belloni
Hi, This is my first post on the list. My name is Antonio. I am a CS grad student and my field of study is about databases and information retrieval. To get some practical knowledge, I've been studying Postgresql codebase for a while. Now I would like to contribute with some code and I've chosen

Contributing with code

2017-12-27 Thread Antonio Belloni
Hi, This is my first post on the list. My name is Antonio. I am a CS grad student and my field of study is about databases and information retrieval. To get some practical knowledge, I've been studying Postgresql codebase for a while. Now I would like to contribute with some code and I've chosen

Re: Contributing with code

2017-12-28 Thread Peter Eisentraut
On 12/27/17 15:18, Antonio Belloni wrote: > I checked the code of pg_tablespace_databases, defined in > src/backend/utils/adt/misc.c, and see that it uses a much simpler > approach : It just reads the tablespaces directories and return the name > of the directories that represents databases OIDs. 

Re: Contributing with code

2017-12-28 Thread Craig Ringer
On 28 December 2017 at 23:05, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/27/17 15:18, Antonio Belloni wrote: > > I checked the code of pg_tablespace_databases, defined in > > src/backend/utils/adt/misc.c, and see that it uses a much simpler > > approach : It just reads the

Re: Contributing with code

2017-12-31 Thread Robert Haas
On Thu, Dec 28, 2017 at 5:42 PM, Craig Ringer wrote: > Well, it's arguably solveable, if the solution is to allow at least limited > cross-database access to catalog relations. I think this is a bad idea. It's bound to add complexity and fragility to the system and I don't think it's worth it.

Re: Contributing with code

2017-12-31 Thread Peter Geoghegan
On Sun, Dec 31, 2017 at 6:35 PM, Robert Haas wrote: > Also, let's delete the TODO list. People keep using it as a source of > project ideas, and that's bad. It would be great if the TODO list was deleted IMV. Choosing the right project is one of the hardest and most important parts of successfu

Re: Contributing with code

2017-12-31 Thread Craig Ringer
On 1 January 2018 at 03:27, Peter Geoghegan wrote: > On Sun, Dec 31, 2017 at 6:35 PM, Robert Haas > wrote: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > It would be great if the TODO list was deleted IMV. > > Choosing the right

Re: Contributing with code

2018-01-02 Thread Peter Eisentraut
On 12/31/17 22:43, Craig Ringer wrote: > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  That might actually be useful. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Contributing with code

2018-01-02 Thread Christopher Browne
On 2 January 2018 at 17:52, Peter Eisentraut wrote: > On 12/31/17 22:43, Craig Ringer wrote: >> I'd rather rename it the "stuck, hard and abandoned projects list" ;) > > That might actually be useful. Yep, agreed. Though it might do better to describe it in *slightly* more positive terms, and/or

Re: Contributing with code

2018-01-02 Thread Noah Misch
On Tue, Jan 02, 2018 at 05:52:37PM -0500, Peter Eisentraut wrote: > On 12/31/17 22:43, Craig Ringer wrote: > > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  > > That might actually be useful. +1. When I do refer to a TODO entry, it's usually because the entry bears a lis

Re: Contributing with code

2018-01-02 Thread Stephen Frost
Noah, all, * Noah Misch (n...@leadboat.com) wrote: > On Tue, Jan 02, 2018 at 05:52:37PM -0500, Peter Eisentraut wrote: > > On 12/31/17 22:43, Craig Ringer wrote: > > > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  > > > > That might actually be useful. > > +1. When I do

Re: Contributing with code

2018-01-05 Thread Antonio Belloni
Sorry, but I did not want to start a flaming war against the TODO list with my first message. In all the other open source projects I have contributed code, the TODO list is always a start point to newcomers. There's no explicit message in the Postgresql TODO list saying that the projects there are

Re: Contributing with code

2018-01-05 Thread Alvaro Herrera
Antonio Belloni wrote: > Sorry, but I did not want to start a flaming war against the TODO list with > my first message. In all the other open source projects I have contributed > code, the TODO list is always a start point to newcomers. There's no > explicit message in the Postgresql TODO list say

Re: Contributing with code

2018-01-02 Thread Peter Eisentraut
On 12/31/17 22:43, Craig Ringer wrote: > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  That might actually be useful. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Contributing with code

2018-01-02 Thread Christopher Browne
On 2 January 2018 at 17:52, Peter Eisentraut wrote: > On 12/31/17 22:43, Craig Ringer wrote: >> I'd rather rename it the "stuck, hard and abandoned projects list" ;) > > That might actually be useful. Yep, agreed. Though it might do better to describe it in *slightly* more positive terms, and/or

Re: Contributing with code

2018-01-02 Thread Noah Misch
On Tue, Jan 02, 2018 at 05:52:37PM -0500, Peter Eisentraut wrote: > On 12/31/17 22:43, Craig Ringer wrote: > > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  > > That might actually be useful. +1. When I do refer to a TODO entry, it's usually because the entry bears a lis

Re: Contributing with code

2018-01-02 Thread Stephen Frost
Noah, all, * Noah Misch (n...@leadboat.com) wrote: > On Tue, Jan 02, 2018 at 05:52:37PM -0500, Peter Eisentraut wrote: > > On 12/31/17 22:43, Craig Ringer wrote: > > > I'd rather rename it the "stuck, hard and abandoned projects list" ;)  > > > > That might actually be useful. > > +1. When I do

Re: Contributing with code

2018-01-05 Thread Antonio Belloni
Sorry, but I did not want to start a flaming war against the TODO list with my first message. In all the other open source projects I have contributed code, the TODO list is always a start point to newcomers. There's no explicit message in the Postgresql TODO list saying that the projects there are

Re: Contributing with code

2018-01-05 Thread Alvaro Herrera
Antonio Belloni wrote: > Sorry, but I did not want to start a flaming war against the TODO list with > my first message. In all the other open source projects I have contributed > code, the TODO list is always a start point to newcomers. There's no > explicit message in the Postgresql TODO list say

Re: Contributing with code

2017-12-28 Thread Peter Eisentraut
On 12/27/17 15:18, Antonio Belloni wrote: > I checked the code of pg_tablespace_databases, defined in > src/backend/utils/adt/misc.c, and see that it uses a much simpler > approach : It just reads the tablespaces directories and return the name > of the directories that represents databases OIDs. 

Re: Contributing with code

2017-12-28 Thread Craig Ringer
On 28 December 2017 at 23:05, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/27/17 15:18, Antonio Belloni wrote: > > I checked the code of pg_tablespace_databases, defined in > > src/backend/utils/adt/misc.c, and see that it uses a much simpler > > approach : It just reads the

Re: Contributing with code

2017-12-31 Thread Robert Haas
On Thu, Dec 28, 2017 at 5:42 PM, Craig Ringer wrote: > Well, it's arguably solveable, if the solution is to allow at least limited > cross-database access to catalog relations. I think this is a bad idea. It's bound to add complexity and fragility to the system and I don't think it's worth it.

Re: Contributing with code

2017-12-31 Thread Peter Geoghegan
On Sun, Dec 31, 2017 at 6:35 PM, Robert Haas wrote: > Also, let's delete the TODO list. People keep using it as a source of > project ideas, and that's bad. It would be great if the TODO list was deleted IMV. Choosing the right project is one of the hardest and most important parts of successfu

Re: Contributing with code

2017-12-31 Thread Craig Ringer
On 1 January 2018 at 03:27, Peter Geoghegan wrote: > On Sun, Dec 31, 2017 at 6:35 PM, Robert Haas > wrote: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > It would be great if the TODO list was deleted IMV. > > Choosing the right

TODO list (was Re: Contributing with code)

2017-12-31 Thread Tom Lane
Robert Haas writes: > Also, let's delete the TODO list. People keep using it as a source of > project ideas, and that's bad. If we're not going to maintain/curate it properly, I agree it's not worth keeping it around. But I'd rather see somebody put some effort into it ...

TODO list (was Re: Contributing with code)

2017-12-31 Thread Tom Lane
Robert Haas writes: > Also, let's delete the TODO list. People keep using it as a source of > project ideas, and that's bad. If we're not going to maintain/curate it properly, I agree it's not worth keeping it around. But I'd rather see somebody put some effort into it ...

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread Stephen Frost
Tom, Robert, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > If we're not going to maintain/curate it properly, I agree it's not > worth keeping it around. But I'd

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread David G. Johnston
On Sun, Dec 31, 2017 at 11:42 AM, Tom Lane wrote: > Robert Haas writes: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > If we're not going to maintain/curate it properly, I agree it's not > worth keeping it around. But I'd rather

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread Peter Geoghegan
On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: > If we're not going to maintain/curate it properly, I agree it's not > worth keeping it around. But I'd rather see somebody put some effort > into it ... If somebody was going to resolve to put some effort into maintaining it to a high standard

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Robert Haas
On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: > On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: >> If we're not going to maintain/curate it properly, I agree it's not >> worth keeping it around. But I'd rather see somebody put some effort >> into it ... > > If somebody was going to r

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Robert Haas
On Sun, Dec 31, 2017 at 1:51 PM, Stephen Frost wrote: > The todo entry even talks about why it's difficult to do and what the > expected way to go about doing it is (that is, connect to each database > that has objects in the tablespace and query it to find out what's in > the tablespace). Craig'

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Robert Haas
On Sun, Dec 31, 2017 at 2:02 PM, David G. Johnston wrote: > It probably needs three sub-sections. Fist the raw ideas put forth by > people not capable of implementation but needing capabilities; these get > moved to one of two sections: ideas that have gotten some attention by core > that have me

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Dec 31, 2017 at 1:51 PM, Stephen Frost wrote: > > The todo entry even talks about why it's difficult to do and what the > > expected way to go about doing it is (that is, connect to each database > > that has objects in the tablespace

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Joshua D. Drake
On 01/02/2018 11:17 AM, Robert Haas wrote: On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: If we're not going to maintain/curate it properly, I agree it's not worth keeping it around. But I'd rather see somebody put some effort into i

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Patrick Krecker
On Tue, Jan 2, 2018 at 3:42 PM, Joshua D. Drake wrote: > On 01/02/2018 11:17 AM, Robert Haas wrote: >> >> On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: >>> >>> On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: If we're not going to maintain/curate it properly, I agree it's no

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Stephen Frost
Greetings, * Patrick Krecker (pkrec...@gmail.com) wrote: > As a person looking to become a postgres contributor, perhaps I can > offer some perspective on this. I think there is value in providing > *some* starting point for new contributors in the form of concrete > problems to solve. The value I

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread David Rowley
On 3 January 2018 at 13:12, Patrick Krecker wrote: > As a person looking to become a postgres contributor, perhaps I can > offer some perspective on this. I think there is value in providing > *some* starting point for new contributors in the form of concrete > problems to solve. The value I hope

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Vik Fearing
On 01/03/2018 03:50 AM, David Rowley wrote: > On 3 January 2018 at 13:12, Patrick Krecker wrote: >> As a person looking to become a postgres contributor, perhaps I can >> offer some perspective on this. I think there is value in providing >> *some* starting point for new contributors in the form o

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Jeff Janes
On Tue, Jan 2, 2018 at 2:48 PM, Robert Haas wrote: > On Sun, Dec 31, 2017 at 2:02 PM, David G. Johnston > wrote: > > It probably needs three sub-sections. Fist the raw ideas put forth by > > people not capable of implementation but needing capabilities; these get > > moved to one of two section

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Jeff Janes
On Tue, Jan 2, 2018 at 6:42 PM, Joshua D. Drake wrote: > On 01/02/2018 11:17 AM, Robert Haas wrote: > >> On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: >> >>> On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: >>> If we're not going to maintain/curate it properly, I agree it's not

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Alvaro Herrera
I think deleting the TODO list is a bad idea -- it contains very useful pointers to previous discussion on hard topics. Jeff Janes wrote: > On Tue, Jan 2, 2018 at 2:48 PM, Robert Haas wrote: > > It also has a note at the top saying we think it's complete, but we > > don't think that, or I don'

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Joshua D. Drake
On 01/03/2018 07:49 AM, Jeff Janes wrote: O.k. what does it tell us though? Is it a resource issue? Is it a barrier of entry issue? Lack of ownership/ruthlessness.  While I can edit it to remove items that don't seem desirable (or comprehensible, or whatever) I'm not likely to do so, unless

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Peter Eisentraut
On 1/3/18 11:10, Alvaro Herrera wrote: > This text was added by [1] as saying: > > This list contains '''some known PostgreSQL bugs and feature > > requests''' and we hope it contains all such > (before this, it said "all known Pg bugs" which seemed too optimistic, > so the correction w

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Alvaro Herrera
Joshua D. Drake wrote: > Heck we could go a step further and actually allow (authenticated) voting on > various features. This would provide the community the ability to more > easily interact with -hackers on various features that would be desirable. There's already https://postgresql.uservoice.

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Joshua D. Drake
On 01/03/2018 09:00 AM, Alvaro Herrera wrote: Joshua D. Drake wrote: There's already https://postgresql.uservoice.com/forums/21853-general which seems to work pretty well. Here's the list of completed items: https://postgresql.uservoice.com/forums/21853-general?status_id=124172 Well that's in

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Joshua D. Drake
On 01/02/2018 11:17 AM, Robert Haas wrote: On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: If we're not going to maintain/curate it properly, I agree it's not worth keeping it around. But I'd rather see somebody put some effort into i

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Patrick Krecker
On Tue, Jan 2, 2018 at 3:42 PM, Joshua D. Drake wrote: > On 01/02/2018 11:17 AM, Robert Haas wrote: >> >> On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: >>> >>> On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: If we're not going to maintain/curate it properly, I agree it's no

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Stephen Frost
Greetings, * Patrick Krecker (pkrec...@gmail.com) wrote: > As a person looking to become a postgres contributor, perhaps I can > offer some perspective on this. I think there is value in providing > *some* starting point for new contributors in the form of concrete > problems to solve. The value I

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread David Rowley
On 3 January 2018 at 13:12, Patrick Krecker wrote: > As a person looking to become a postgres contributor, perhaps I can > offer some perspective on this. I think there is value in providing > *some* starting point for new contributors in the form of concrete > problems to solve. The value I hope

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Vik Fearing
On 01/03/2018 03:50 AM, David Rowley wrote: > On 3 January 2018 at 13:12, Patrick Krecker wrote: >> As a person looking to become a postgres contributor, perhaps I can >> offer some perspective on this. I think there is value in providing >> *some* starting point for new contributors in the form o

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Jeff Janes
On Tue, Jan 2, 2018 at 2:48 PM, Robert Haas wrote: > On Sun, Dec 31, 2017 at 2:02 PM, David G. Johnston > wrote: > > It probably needs three sub-sections. Fist the raw ideas put forth by > > people not capable of implementation but needing capabilities; these get > > moved to one of two section

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Jeff Janes
On Tue, Jan 2, 2018 at 6:42 PM, Joshua D. Drake wrote: > On 01/02/2018 11:17 AM, Robert Haas wrote: > >> On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: >> >>> On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: >>> If we're not going to maintain/curate it properly, I agree it's not

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Alvaro Herrera
I think deleting the TODO list is a bad idea -- it contains very useful pointers to previous discussion on hard topics. Jeff Janes wrote: > On Tue, Jan 2, 2018 at 2:48 PM, Robert Haas wrote: > > It also has a note at the top saying we think it's complete, but we > > don't think that, or I don'

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Joshua D. Drake
On 01/03/2018 07:49 AM, Jeff Janes wrote: O.k. what does it tell us though? Is it a resource issue? Is it a barrier of entry issue? Lack of ownership/ruthlessness.  While I can edit it to remove items that don't seem desirable (or comprehensible, or whatever) I'm not likely to do so, unless

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Peter Eisentraut
On 1/3/18 11:10, Alvaro Herrera wrote: > This text was added by [1] as saying: > > This list contains '''some known PostgreSQL bugs and feature > > requests''' and we hope it contains all such > (before this, it said "all known Pg bugs" which seemed too optimistic, > so the correction w

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Alvaro Herrera
Joshua D. Drake wrote: > Heck we could go a step further and actually allow (authenticated) voting on > various features. This would provide the community the ability to more > easily interact with -hackers on various features that would be desirable. There's already https://postgresql.uservoice.

Re: TODO list (was Re: Contributing with code)

2018-01-03 Thread Joshua D. Drake
On 01/03/2018 09:00 AM, Alvaro Herrera wrote: Joshua D. Drake wrote: There's already https://postgresql.uservoice.com/forums/21853-general which seems to work pretty well. Here's the list of completed items: https://postgresql.uservoice.com/forums/21853-general?status_id=124172 Well that's in

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread Stephen Frost
Tom, Robert, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > If we're not going to maintain/curate it properly, I agree it's not > worth keeping it around. But I'd

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread David G. Johnston
On Sun, Dec 31, 2017 at 11:42 AM, Tom Lane wrote: > Robert Haas writes: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > If we're not going to maintain/curate it properly, I agree it's not > worth keeping it around. But I'd rather

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread Peter Geoghegan
On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: > If we're not going to maintain/curate it properly, I agree it's not > worth keeping it around. But I'd rather see somebody put some effort > into it ... If somebody was going to resolve to put some effort into maintaining it to a high standard

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Robert Haas
On Sun, Dec 31, 2017 at 2:31 PM, Peter Geoghegan wrote: > On Sun, Dec 31, 2017 at 10:42 AM, Tom Lane wrote: >> If we're not going to maintain/curate it properly, I agree it's not >> worth keeping it around. But I'd rather see somebody put some effort >> into it ... > > If somebody was going to r

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Robert Haas
On Sun, Dec 31, 2017 at 1:51 PM, Stephen Frost wrote: > The todo entry even talks about why it's difficult to do and what the > expected way to go about doing it is (that is, connect to each database > that has objects in the tablespace and query it to find out what's in > the tablespace). Craig'

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Robert Haas
On Sun, Dec 31, 2017 at 2:02 PM, David G. Johnston wrote: > It probably needs three sub-sections. Fist the raw ideas put forth by > people not capable of implementation but needing capabilities; these get > moved to one of two sections: ideas that have gotten some attention by core > that have me

Re: TODO list (was Re: Contributing with code)

2018-01-02 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Dec 31, 2017 at 1:51 PM, Stephen Frost wrote: > > The todo entry even talks about why it's difficult to do and what the > > expected way to go about doing it is (that is, connect to each database > > that has objects in the tablespace