Re: Convert sepgsql tests to TAP

2024-08-27 Thread Peter Eisentraut
98923aa1e1 -- 2.46.0 From 9322b87aad3d207731dc71853f39cb9651ea8a18 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 27 Aug 2024 09:52:45 +0200 Subject: [PATCH v2 2/2] Convert sepgsql tests to TAP Add a TAP test for sepgsql. This automates the previously required manual setup before the

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Andreas Karlsson
On 7/24/24 10:35 PM, Tom Lane wrote: Andreas Karlsson writes: 1) As I said earlier I think we should remove the old code. I agree that carrying two versions of the test doesn't seem great. However, a large part of the purpose of test_sepgsql is to help people debug their sepgsql setup, which

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Tom Lane
Andreas Karlsson writes: > 1) As I said earlier I think we should remove the old code. I agree that carrying two versions of the test doesn't seem great. However, a large part of the purpose of test_sepgsql is to help people debug their sepgsql setup, which is why it goes to great lengths to prin

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Andreas Karlsson
On 7/24/24 6:33 PM, Peter Eisentraut wrote: On 24.07.24 16:31, Andreas Karlsson wrote: I took a quick look at the patch and I like that we standardize things a bit. But one thing I am not a fan of are all the use of sed and awk in the Perl script. I would prefer if that logic happened all in Pe

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Joe Conway
On 7/24/24 12:36, Tom Lane wrote: Peter Eisentraut writes: In my experience, the tests (both the old and the proposed new) only work on Red Hat-like platforms. I had also tried on Debian but decided that it won't work. Yeah, Red Hat is pretty much the only vendor that has pushed SELinux far

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Tom Lane
Peter Eisentraut writes: > In my experience, the tests (both the old and the proposed new) only > work on Red Hat-like platforms. I had also tried on Debian but decided > that it won't work. Yeah, Red Hat is pretty much the only vendor that has pushed SELinux far enough to be usable by non-wiz

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Andreas Karlsson
On 7/24/24 6:31 PM, Peter Eisentraut wrote: On 24.07.24 18:29, Andreas Karlsson wrote: Peter, what did you do to get the tests running? And should we fix these tests to make them more user friendly? In my experience, the tests (both the old and the proposed new) only work on Red Hat-like plat

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Peter Eisentraut
On 24.07.24 16:31, Andreas Karlsson wrote: I took a quick look at the patch and I like that we standardize things a bit. But one thing I am not a fan of are all the use of sed and awk in the Perl script. I would prefer if that logic happened all in Perl, especially since we have some of it in P

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Peter Eisentraut
On 24.07.24 18:29, Andreas Karlsson wrote: On 7/24/24 4:31 PM, Andreas Karlsson wrote: I have not yet set up an VM with selinux to try the patch out for real but will do so later. I almost got the tests running but it required way too many manual steps to just get there and I gave up after ju

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Andreas Karlsson
On 7/24/24 4:31 PM, Andreas Karlsson wrote: I have not yet set up an VM with selinux to try the patch out for real but will do so later. I almost got the tests running but it required way too many manual steps to just get there and I gave up after just getting segfaults. I had to edit sepgsql

Re: Convert sepgsql tests to TAP

2024-07-24 Thread Andreas Karlsson
I took a quick look at the patch and I like that we standardize things a bit. But one thing I am not a fan of are all the use of sed and awk in the Perl script. I would prefer if that logic happened all in Perl, especially since we have some of it in Perl (e.g. chomp). Also I wonder if we shoul

Convert sepgsql tests to TAP

2024-05-12 Thread Peter Eisentraut
d tests in some way. From 2f8e73932b1068caf696582487de9e100fcd46be Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 13 May 2024 07:55:55 +0200 Subject: [PATCH v1] Convert sepgsql tests to TAP Add a TAP test for sepgsql. This automates the previously required manual setup before the test. The actual tests are still r