Re: Corner-case bug in pg_rewind

On 04/12/2020 00:16, Heikki Linnakangas wrote: On 03/12/2020 16:10, Heikki Linnakangas wrote: On 02/12/2020 15:26, Ian Barwick wrote: On 02/12/2020 20:13, Heikki Linnakangas wrote: Attached are two patches. The first patch is your original patch, unmodified (except for a cosmetic rename of the

Re: Corner-case bug in pg_rewind

On 03/12/2020 16:10, Heikki Linnakangas wrote: On 02/12/2020 15:26, Ian Barwick wrote: On 02/12/2020 20:13, Heikki Linnakangas wrote: Attached are two patches. The first patch is your original patch, unmodified (except for a cosmetic rename of the test file). The second patch builds on that, de

Re: Corner-case bug in pg_rewind

чт, 3 дек. 2020 г. в 19:15, Heikki Linnakangas : > On 03/12/2020 16:49, Pavel Borisov wrote: > > Ok, pushed and backpatched this now. > > > > Very nice! > > Thanks to you all! > > Thanks for the review, Pavel! I just realized that I forgot to credit > you in the commit message. I'm sorry. > Do

Re: Corner-case bug in pg_rewind

On 03/12/2020 16:49, Pavel Borisov wrote: Ok, pushed and backpatched this now. Very nice! Thanks to you all! Thanks for the review, Pavel! I just realized that I forgot to credit you in the commit message. I'm sorry. - Heikki

Re: Corner-case bug in pg_rewind

> > Ok, pushed and backpatched this now. > Very nice! Thanks to you all! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com

Re: Corner-case bug in pg_rewind

On 02/12/2020 15:26, Ian Barwick wrote: On 02/12/2020 20:13, Heikki Linnakangas wrote: Attached are two patches. The first patch is your original patch, unmodified (except for a cosmetic rename of the test file). The second patch builds on that, demonstrating and fixing the issue I mentioned. It

Re: Corner-case bug in pg_rewind

On 02/12/2020 20:13, Heikki Linnakangas wrote: On 01/12/2020 16:52, Pavel Borisov wrote:     Status update for a commitfest entry.     The patch is Waiting on Author for some time. As this is a bug fix,     I am     moving it to the next CF.     Ian, are you planning to continue working on it?

Re: Corner-case bug in pg_rewind

On 01/12/2020 16:52, Pavel Borisov wrote: Status update for a commitfest entry. The patch is Waiting on Author for some time. As this is a bug fix, I am moving it to the next CF. Ian, are you planning to continue working on it? As a reviewer, I consider the patch useful and

Re: Corner-case bug in pg_rewind

> > Status update for a commitfest entry. > > The patch is Waiting on Author for some time. As this is a bug fix, I am > moving it to the next CF. > Ian, are you planning to continue working on it? > As a reviewer, I consider the patch useful and good overall. The comments I left were purely cosme

Re: Corner-case bug in pg_rewind

On 16.11.2020 05:49, Ian Lawrence Barwick wrote: Note that the patch may require reworking for HEAD due to changes in commit 9c4f5192f6. I'll try to take another look this week. Regards Ian Barwick -- EnterpriseDB: https://www.enterprisedb.com Status update for a commitfest entry. The

Re: Corner-case bug in pg_rewind

> > > 1. Comment regarding > > -- > > 347 * Check for the possibility that the target is in fact a > direct > > 348 * ancestor of the source. In that case, there is no > divergent history > > 349 * in the target that needs rewinding. > > -- > > are better be refor

Re: Corner-case bug in pg_rewind

2020年11月10日(火) 18:07 Pavel Borisov : > > I did some effort to review your patch which seems legit to me. Thanks for the review and feedback. > I think some minor things are better to be improved i.e. > > 1. Comment regarding > -- > 347 * Check for the possibility that the target is i

Re: Corner-case bug in pg_rewind

I did some effort to review your patch which seems legit to me. I think some minor things are better to be improved i.e. 1. Comment regarding -- 347 * Check for the possibility that the target is in fact a direct 348 * ancestor of the source. In that case, there is no diverge

Re: Corner-case bug in pg_rewind

On 11/09/2020 09:42, Ian Barwick wrote: Take the following cluster with: - node1 (initial primary) - node2 (standby) - node3 (standby) Following activity takes place (greatly simplified from a real-world situation): 1. node1 is shut down. 2. node3 is promoted 3. node2 is attached to no

Corner-case bug in pg_rewind

Hi Take the following cluster with: - node1 (initial primary) - node2 (standby) - node3 (standby) Following activity takes place (greatly simplified from a real-world situation): 1. node1 is shut down. 2. node3 is promoted 3. node2 is attached to node3. 4. node1 is attached to node3 5. nod