Re: CountDBSubscriptions check in dropdb

2019-11-10 Thread Amit Kapila
On Mon, Nov 11, 2019 at 6:43 AM Michael Paquier wrote: > > On Sun, Nov 10, 2019 at 08:48:27AM +0530, Amit Kapila wrote: > > I am planning to go with Peter's suggestion and will push in > > HEAD-only. So, I think that should be fine. > > I was just looking at this thread, and my take would be to j

Re: CountDBSubscriptions check in dropdb

2019-11-10 Thread Michael Paquier
On Sun, Nov 10, 2019 at 08:48:27AM +0530, Amit Kapila wrote: > I am planning to go with Peter's suggestion and will push in > HEAD-only. So, I think that should be fine. I was just looking at this thread, and my take would be to just apply that on HEAD. Good catch by the way. -- Michael signat

Re: CountDBSubscriptions check in dropdb

2019-11-09 Thread Amit Kapila
On Sat, Nov 9, 2019 at 9:38 PM Tom Lane wrote: > > Amit Kapila writes: > > On Sat, Nov 9, 2019 at 3:58 PM Peter Eisentraut > > wrote: > >> On 2019-11-08 14:38, Amit Kapila wrote: > >>> I am planning to commit and backpatch this till PG10 where it was > >>> introduced on Monday morning (IST). Pa

Re: CountDBSubscriptions check in dropdb

2019-11-09 Thread Tom Lane
Amit Kapila writes: > On Sat, Nov 9, 2019 at 3:58 PM Peter Eisentraut > wrote: >> On 2019-11-08 14:38, Amit Kapila wrote: >>> I am planning to commit and backpatch this till PG10 where it was >>> introduced on Monday morning (IST). Pavel agreed that this is a good >>> change in the other thread

Re: CountDBSubscriptions check in dropdb

2019-11-09 Thread Amit Kapila
On Sat, Nov 9, 2019 at 3:58 PM Peter Eisentraut wrote: > > On 2019-11-08 14:38, Amit Kapila wrote: > > I am planning to commit and backpatch this till PG10 where it was > > introduced on Monday morning (IST). Pavel agreed that this is a good > > change in the other thread where we need it [1]. I

Re: CountDBSubscriptions check in dropdb

2019-11-09 Thread Peter Eisentraut
On 2019-11-08 14:38, Amit Kapila wrote: I am planning to commit and backpatch this till PG10 where it was introduced on Monday morning (IST). Pavel agreed that this is a good change in the other thread where we need it [1]. It is not an urgent thing, so I can wait if we think this is not a good

Re: CountDBSubscriptions check in dropdb

2019-11-08 Thread Amit Kapila
On Mon, Oct 21, 2019 at 11:43 AM Amit Kapila wrote: > > While reviewing Pavel's patch for a new option in Drop Database > command [1], I noticed that the check for CountDBSubscriptions in > dropdb() is done after we kill the autovac workers and allowed other > backends to exit via CountOtherDBBack

CountDBSubscriptions check in dropdb

2019-10-20 Thread Amit Kapila
While reviewing Pavel's patch for a new option in Drop Database command [1], I noticed that the check for CountDBSubscriptions in dropdb() is done after we kill the autovac workers and allowed other backends to exit via CountOtherDBBackends. Now, if there are already active subscritions due to whi