Re: Crash in BRIN summarization

2020-01-20 Thread Alvaro Herrera
On 2020-Jan-20, Heikki Linnakangas wrote: > Sorry, forgot all about it. Pushed now. Thank you! -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Crash in BRIN summarization

2020-01-20 Thread Heikki Linnakangas
On 17/01/2020 23:35, Alvaro Herrera wrote: On 2019-Aug-28, Heikki Linnakangas wrote: I bumped into a little bug in BRIN, while hacking on something unrelated. This causes a segfault, or an assertion failure if assertions are enabled: Heikki, I just noticed that you haven't pushed this bugfix.

Re: Crash in BRIN summarization

2020-01-17 Thread Alvaro Herrera
On 2019-Aug-28, Heikki Linnakangas wrote: > I bumped into a little bug in BRIN, while hacking on something unrelated. > This causes a segfault, or an assertion failure if assertions are enabled: Heikki, I just noticed that you haven't pushed this bugfix. Would you like me to? (If I don't hear f

Re: Crash in BRIN summarization

2019-08-28 Thread Tom Lane
Heikki Linnakangas writes: > I bumped into a little bug in BRIN, while hacking on something > unrelated. This causes a segfault, or an assertion failure if assertions > are enabled: Good catch. > Fix attached. Hm, I don't particularly care for directly comparing Datum values like that. We do

Re: Crash in BRIN summarization

2019-08-28 Thread Emre Hasegeli
Thank you for your fix. > This assumes that the merge function returns a newly-palloc'd value. > That's a shaky assumption; if one of the arguments is an empty range, > range_merge() returns the other argument, rather than a newly > constructed value. And surely we can't assume assume that for > u

Crash in BRIN summarization

2019-08-28 Thread Heikki Linnakangas
I bumped into a little bug in BRIN, while hacking on something unrelated. This causes a segfault, or an assertion failure if assertions are enabled: CREATE TABLE brintest (n numrange); CREATE INDEX brinidx ON brintest USING brin (n); INSERT INTO brintest VALUES ('empty'); INSERT INTO brintest