Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Wed, Aug 11, 2021 at 5:54 AM Robert Haas wrote: > Yeah. I tend to feel like this is the kind of thing where it's not > likely to be 100% obvious to users how it all works no matter what we > put in the documentation, and that some of the behavior of a system > has to be learned just by trying

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Aug 10, 2021 at 5:53 PM David G. Johnston wrote: >> The final portion of the patch adds new regression tests. I'm not >> going to say that this is completely without merit, because it can be >> useful to know if some patch changes the behavior, but I guess I don't >> really see a whole

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Aug 10, 2021 at 12:04 PM Robert Haas wrote: > On Tue, Mar 9, 2021 at 10:09 AM David G. Johnston > wrote: > > Frankly, I am hoping for a bit more constructive feedback and even > collaboration from a committer, specifically Tom, on this one given the > outstanding user complaints

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Mar 9, 2021 at 10:09 AM David G. Johnston wrote: > Frankly, I am hoping for a bit more constructive feedback and even > collaboration from a committer, specifically Tom, on this one given the > outstanding user complaints received on the topic, our disagreement regarding > fixing it

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Jul 13, 2021 at 3:30 AM Ibrar Ahmed wrote: > > > On Tue, Mar 9, 2021 at 9:01 PM David Steele wrote: > >> On 3/9/21 10:08 AM, David G. Johnston wrote: >> > >> > On Tuesday, March 9, 2021, David Steele > > > wrote: >> > >> > Further, I think we should close

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Mar 9, 2021 at 9:01 PM David Steele wrote: > On 3/9/21 10:08 AM, David G. Johnston wrote: > > > > On Tuesday, March 9, 2021, David Steele > > wrote: > > > > Further, I think we should close this entry at the end of the CF if > > it does not attract

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On 3/9/21 10:08 AM, David G. Johnston wrote: On Tuesday, March 9, 2021, David Steele > wrote: Further, I think we should close this entry at the end of the CF if it does not attract committer interest. Tom is not in favor of the patch and it appears

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tuesday, March 9, 2021, David Steele wrote: > > Further, I think we should close this entry at the end of the CF if it > does not attract committer interest. Tom is not in favor of the patch and > it appears Alexander decided not to commit it. > Pavel re-reviewed it and was fine with

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

Hi David, On 11/23/20 3:31 PM, Anastasia Lubennikova wrote: On 30.09.2020 05:00, David G. Johnston wrote: v5 attached, looking at this fresh and with some comments to consider. I ended up just combining both patches into one. I did away with the glossary changes altogether, and the

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On 30.09.2020 05:00, David G. Johnston wrote: On Tue, Sep 15, 2020 at 3:48 PM Alexander Korotkov mailto:aekorot...@gmail.com>> wrote: Hi! I've skimmed through the thread and checked the patchset. Everything looks good, except one paragraph, which doesn't look completely clear.

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

st 30. 9. 2020 v 4:01 odesílatel David G. Johnston < david.g.johns...@gmail.com> napsal: > On Tue, Sep 15, 2020 at 3:48 PM Alexander Korotkov > wrote: > >> Hi! >> >> I've skimmed through the thread and checked the patchset. Everything >> looks good, except one paragraph, which doesn't look

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Sep 15, 2020 at 3:48 PM Alexander Korotkov wrote: > Hi! > > I've skimmed through the thread and checked the patchset. Everything > looks good, except one paragraph, which doesn't look completely clear. > > + > + This emulates the functionality provided by > +but sets the created

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Wed, Sep 16, 2020 at 4:42 PM Tom Lane wrote: > "David G. Johnston" writes: > > My main point here is that writing "CREATE TYPE typename AS DOMAIN" would > > be expected, with the appropriate sub-specification, similar to "CREATE > > TYPE typename AS RANGE". > > Well, that point seems

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Wed, Sep 16, 2020 at 4:42 PM Tom Lane wrote: > "David G. Johnston" writes: > > My main point here is that writing "CREATE TYPE typename AS DOMAIN" would > > be expected, with the appropriate sub-specification, similar to "CREATE > > TYPE typename AS RANGE". > > Well, that point seems

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

"David G. Johnston" writes: > My main point here is that writing "CREATE TYPE typename AS DOMAIN" would > be expected, with the appropriate sub-specification, similar to "CREATE > TYPE typename AS RANGE". Well, that point seems entirely invented. CREATE DOMAIN is in the SQL standard:

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Sep 15, 2020 at 3:48 PM Alexander Korotkov wrote: > Hi! > > I've skimmed through the thread and checked the patchset. Everything > looks good, except one paragraph, which doesn't look completely clear. > > + > + This emulates the functionality provided by > +but sets the created

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

Hi! I've skimmed through the thread and checked the patchset. Everything looks good, except one paragraph, which doesn't look completely clear. + + This emulates the functionality provided by +but sets the created object's + type definition + to domain. + As I get it states that

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Jul 14, 2020 at 7:21 AM Pavel Stehule wrote: > út 14. 7. 2020 v 16:09 odesílatel David G. Johnston < > david.g.johns...@gmail.com> napsal: > >> On Tue, Jul 14, 2020 at 6:56 AM Pavel Stehule >> wrote: >> >>> út 14. 7. 2020 v 15:55 odesílatel David G. Johnston < >>>

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

út 14. 7. 2020 v 16:09 odesílatel David G. Johnston < david.g.johns...@gmail.com> napsal: > On Tue, Jul 14, 2020 at 6:56 AM Pavel Stehule > wrote: > >> út 14. 7. 2020 v 15:55 odesílatel David G. Johnston < >> david.g.johns...@gmail.com> napsal: >> >>> Further comments welcome so I'm putting it

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Jul 14, 2020 at 6:56 AM Pavel Stehule wrote: > út 14. 7. 2020 v 15:55 odesílatel David G. Johnston < > david.g.johns...@gmail.com> napsal: > >> Further comments welcome so I'm putting it back into needs review for the >> moment while I work on the refactor. >> > > attached fixed patch >

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

út 14. 7. 2020 v 15:55 odesílatel David G. Johnston < david.g.johns...@gmail.com> napsal: > On Tue, Jul 14, 2020 at 5:40 AM Justin Pryzby > wrote: > >> On Tue, Jul 14, 2020 at 07:25:56AM +0200, Pavel Stehule wrote: >> > út 14. 7. 2020 v 0:37 odesílatel David G. Johnston < >>

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Jul 14, 2020 at 5:40 AM Justin Pryzby wrote: > On Tue, Jul 14, 2020 at 07:25:56AM +0200, Pavel Stehule wrote: > > út 14. 7. 2020 v 0:37 odesílatel David G. Johnston < > david.g.johns...@gmail.com> napsal: > > > On Mon, Jul 13, 2020 at 2:12 AM Pavel Stehule > wrote: > > I think so now

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Tue, Jul 14, 2020 at 07:25:56AM +0200, Pavel Stehule wrote: > út 14. 7. 2020 v 0:37 odesílatel David G. Johnston > napsal: > > On Mon, Jul 13, 2020 at 2:12 AM Pavel Stehule > > wrote: > I think so now all changes are correct and valuable. I''l mark this patch > as ready for commit This is

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

út 14. 7. 2020 v 0:37 odesílatel David G. Johnston < david.g.johns...@gmail.com> napsal: > On Mon, Jul 13, 2020 at 2:12 AM Pavel Stehule > wrote: > >> I am reading this patch. I don't think so text for domains and types are >> correct (or minimally it is little bit messy) >> This case is a

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Mon, Jul 13, 2020 at 2:12 AM Pavel Stehule wrote: > I am reading this patch. I don't think so text for domains and types are > correct (or minimally it is little bit messy) > This case is a little bit more complex - domains are not subset of > relations. But relations (in Postgres) extends

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

po 13. 7. 2020 v 11:11 odesílatel Pavel Stehule napsal: > Hi > > čt 18. 6. 2020 v 0:47 odesílatel David G. Johnston < > david.g.johns...@gmail.com> napsal: > >> This is a follow-up to Bug # 16492 which also links to a thread sent to >> -hackers back in 2018. >> >> I'm firmly of the belief that

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

Hi čt 18. 6. 2020 v 0:47 odesílatel David G. Johnston < david.g.johns...@gmail.com> napsal: > This is a follow-up to Bug # 16492 which also links to a thread sent to > -hackers back in 2018. > > I'm firmly of the belief that the existing behavior of DROP relation IF > EXISTS is flawed - it

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On Wed, Jun 17, 2020 at 4:32 PM Tom Lane wrote: > "David G. Johnston" writes: > > I'm firmly of the belief that the existing behavior of DROP relation IF > > EXISTS is flawed - it should not be an error if there is a namespace > > collision but the relkind of the existing relation doesn't match

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

"David G. Johnston" writes: > I'm firmly of the belief that the existing behavior of DROP relation IF > EXISTS is flawed - it should not be an error if there is a namespace > collision but the relkind of the existing relation doesn't match the > relkind set by the DROP command. I don't

DROP relation IF EXISTS Docs and Tests - Bug Fix

This is a follow-up to Bug # 16492 which also links to a thread sent to -hackers back in 2018. I'm firmly of the belief that the existing behavior of DROP relation IF EXISTS is flawed - it should not be an error if there is a namespace collision but the relkind of the existing relation doesn't