On Sun, Mar 5, 2023 at 1:22 PM Peter Smith wrote:
>
> On Fri, Mar 3, 2023 at 10:04 PM Amit Kapila wrote:
> >
> > >
> > > Thanks. Done so in the attached v2.
> > >
> >
> > LGTM. Unless Peter or someone has any comments on this, I'll push this
> > early next week.
> >
>
> No more comments. Patch
On Fri, Mar 3, 2023 at 10:04 PM Amit Kapila wrote:
>
> On Fri, Mar 3, 2023 at 4:13 PM Bharath Rupireddy
> wrote:
> >
> > On Thu, Jan 19, 2023 at 8:36 AM Peter Smith wrote:
> > >
> > > On Wed, Jan 18, 2023 at 6:26 PM Bharath Rupireddy
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > >
On Fri, Mar 3, 2023 at 4:13 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 19, 2023 at 8:36 AM Peter Smith wrote:
> >
> > On Wed, Jan 18, 2023 at 6:26 PM Bharath Rupireddy
> > wrote:
> > >
> > > Hi,
> > >
> > > logicalrep_read_tuple() duplicates code for LOGICALREP_COLUMN_TEXT and
> > >
On Thu, Jan 19, 2023 at 8:36 AM Peter Smith wrote:
>
> On Wed, Jan 18, 2023 at 6:26 PM Bharath Rupireddy
> wrote:
> >
> > Hi,
> >
> > logicalrep_read_tuple() duplicates code for LOGICALREP_COLUMN_TEXT and
> > LOGICALREP_COLUMN_BINARY introduced by commit 9de77b5. While it
> > doesn't hurt
On Wed, Jan 18, 2023 at 6:26 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> logicalrep_read_tuple() duplicates code for LOGICALREP_COLUMN_TEXT and
> LOGICALREP_COLUMN_BINARY introduced by commit 9de77b5. While it
> doesn't hurt anyone, deduplication makes code a bit leaner by 57 bytes
> [1]. I've
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From 9c645a11a56b3729b4f9184e6bfb7a6fcf834692 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy
Date: Wed, 18 Jan 2023 05:14:47 +
Subject: [PATCH v1] Deduplicate
