On Fri, Oct 1, 2021 at 6:36 AM Masahiko Sawada wrote:
>
> On Fri, Oct 1, 2021 at 1:45 AM Jaime Casanova
> wrote:
> >
> > On Tue, Sep 07, 2021 at 11:14:23AM +0530, Amit Kapila wrote:
> > > On Mon, Sep 6, 2021 at 5:29 PM Ashutosh Bapat
> > > wrote:
> > > >
> > > > Yeah, I agree. Sorry for missing
On Fri, Oct 1, 2021 at 1:45 AM Jaime Casanova
wrote:
>
> On Tue, Sep 07, 2021 at 11:14:23AM +0530, Amit Kapila wrote:
> > On Mon, Sep 6, 2021 at 5:29 PM Ashutosh Bapat
> > wrote:
> > >
> > > Yeah, I agree. Sorry for missing that.
> > >
> > > The updated patch looks good to me.
> > >
> >
> >
On Tue, Sep 07, 2021 at 11:14:23AM +0530, Amit Kapila wrote:
> On Mon, Sep 6, 2021 at 5:29 PM Ashutosh Bapat
> wrote:
> >
> > Yeah, I agree. Sorry for missing that.
> >
> > The updated patch looks good to me.
> >
>
> Pushed!
>
This patch is still on "Needs review"!
Should we change it to
Thanks Amit.
On Tue, Sep 7, 2021 at 11:14 AM Amit Kapila wrote:
>
> On Mon, Sep 6, 2021 at 5:29 PM Ashutosh Bapat
> wrote:
> >
> > Yeah, I agree. Sorry for missing that.
> >
> > The updated patch looks good to me.
> >
>
> Pushed!
>
> --
> With Regards,
> Amit Kapila.
--
Best Wishes,
On Mon, Sep 6, 2021 at 5:29 PM Ashutosh Bapat
wrote:
>
> Yeah, I agree. Sorry for missing that.
>
> The updated patch looks good to me.
>
Pushed!
--
With Regards,
Amit Kapila.
Yeah, I agree. Sorry for missing that.
The updated patch looks good to me.
On Mon, Sep 6, 2021 at 3:25 PM Amit Kapila wrote:
> On Tue, Aug 17, 2021 at 11:58 AM Ashutosh Bapat
> wrote:
> >
> > Hi Amit and Andres,
> > Here's updated patch
> >
>
> I think we can log the required information
On Tue, Aug 17, 2021 at 11:58 AM Ashutosh Bapat
wrote:
>
> Hi Amit and Andres,
> Here's updated patch
>
I think we can log the required information immediately after
releasing spinlock, otherwise, the other logs from
LogicalConfirmReceivedLocation() might interleave. I have made that
change and
Hi Amit and Andres,
Here's updated patch
On Mon, Aug 9, 2021 at 11:14 AM Ashutosh Bapat <
ashutosh.ba...@enterprisedb.com> wrote:
>
>
> On Sat, Aug 7, 2021 at 11:40 AM Andres Freund wrote:
>
>> Hi,
>>
>> On 2021-07-12 17:28:15 +0530, Ashutosh Bapat wrote:
>> > On Mon, Jul 12, 2021 at 8:39 AM
On Sat, Aug 7, 2021 at 11:40 AM Andres Freund wrote:
> Hi,
>
> On 2021-07-12 17:28:15 +0530, Ashutosh Bapat wrote:
> > On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila
> wrote:
> >
> > > On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada >
> > > Today, again looking at this patch, I don't think doing
Hi,
On 2021-07-12 17:28:15 +0530, Ashutosh Bapat wrote:
> On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila wrote:
>
> > On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada
> > Today, again looking at this patch, I don't think doing elog inside
> > spinlock is a good idea. We can either release spinlock
On Mon, Jul 12, 2021 at 5:28 PM Ashutosh Bapat
wrote:
>
> On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila wrote:
>>
>> On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada
>> wrote:
>> >
>> > On Fri, May 21, 2021 at 6:00 PM Ashutosh Bapat
>> > wrote:
>> > >
>> > > It's there in CF. I am fine with
On Mon, Jul 12, 2021 at 6:23 PM Amit Kapila wrote:
> On Mon, Jul 12, 2021 at 5:28 PM Ashutosh Bapat
> wrote:
> >
> > On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila
> wrote:
> >>
> >> I have noticed that
> >> a nearby function LogicalIncreaseRestartDecodingForSlot() logs similar
> >> information
On Mon, Jul 12, 2021 at 5:28 PM Ashutosh Bapat
wrote:
>
> On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila wrote:
>>
>> I have noticed that
>> a nearby function LogicalIncreaseRestartDecodingForSlot() logs similar
>> information after releasing spinlock, so it is better to follow the
>> same here as
On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila wrote:
> On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada
> wrote:
> >
> > On Fri, May 21, 2021 at 6:00 PM Ashutosh Bapat
> > wrote:
> > >
> > > It's there in CF. I am fine with PG-15. It will be good to patch the
> back-branches to have this extra
On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada wrote:
>
> On Fri, May 21, 2021 at 6:00 PM Ashutosh Bapat
> wrote:
> >
> > It's there in CF. I am fine with PG-15. It will be good to patch the
> > back-branches to have this extra diagnostic information available.
>
> The patch looks to me.
>
{
On Thu, Jul 8, 2021 at 8:14 PM Daniel Gustafsson wrote:
>
> > On 8 Jul 2021, at 12:56, Amit Kapila wrote:
>
> > Do you or others have any opinion on whether this should be
> > back-patched? I personally prefer it to be a HEAD-only patch.
>
> +1 for only applying this to HEAD. The restart_lsn
> On 8 Jul 2021, at 12:56, Amit Kapila wrote:
> Do you or others have any opinion on whether this should be
> back-patched? I personally prefer it to be a HEAD-only patch.
+1 for only applying this to HEAD. The restart_lsn debug elog has been there
since 2014 so there doesn’t seem to be any
On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada wrote:
>
> On Fri, May 21, 2021 at 6:00 PM Ashutosh Bapat
> wrote:
> >
> >
> >
> > On Fri, May 21, 2021 at 11:26 AM Amit Kapila
> > wrote:
> >>
> >> On Thu, May 20, 2021 at 5:43 PM Ashutosh Bapat
> >> wrote:
> >> >
> >> > Hi
> >> >
On Fri, May 21, 2021 at 6:00 PM Ashutosh Bapat
wrote:
>
>
>
> On Fri, May 21, 2021 at 11:26 AM Amit Kapila wrote:
>>
>> On Thu, May 20, 2021 at 5:43 PM Ashutosh Bapat
>> wrote:
>> >
>> > Hi
>> > LogicalIncreaseRestartDecodingForSlot() has a debug log to report a
>> > new restart_lsn. But the
On Fri, May 21, 2021 at 11:26 AM Amit Kapila
wrote:
> On Thu, May 20, 2021 at 5:43 PM Ashutosh Bapat
> wrote:
> >
> > Hi
> > LogicalIncreaseRestartDecodingForSlot() has a debug log to report a
> > new restart_lsn. But the corresponding function for catalog_xmin.
> > Here's a patch to add the
On Thu, May 20, 2021 at 5:43 PM Ashutosh Bapat
wrote:
>
> Hi
> LogicalIncreaseRestartDecodingForSlot() has a debug log to report a
> new restart_lsn. But the corresponding function for catalog_xmin.
> Here's a patch to add the same.
>
I think this can be useful. One minor comment:
+ elog(DEBUG1,
Hi
LogicalIncreaseRestartDecodingForSlot() has a debug log to report a
new restart_lsn. But the corresponding function for catalog_xmin.
Here's a patch to add the same.
--
Best Wishes,
Ashutosh Bapat
From 5d211016367fe352871647225ead64a2215c3184 Mon Sep 17 00:00:00 2001
From: Ashutosh Bapat
22 matches
Mail list logo
