Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-28 Thread Amit Kapila
On Wed, Aug 28, 2024 at 3:02 PM wrote: > > > > > The next line related to asynchronous replication is also not required. See > > attached. > > Thanks, I found another ".. without losing data". > I'll push this tomorrow unless there are any other suggestions on this patch. -- With Regards, Amit

RE: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-28 Thread Masahiro.Ikeda
> > > > > So, will it be okay if we just remove ".. without losing data" > > > > > from the sentence? Will that avoid the confusion you have? > > > > Yes. Additionally, it would be better to add notes about data > > > > consistency after failover for example > > > > > > > > Note that data consisten

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-28 Thread Amit Kapila
On Wed, Aug 28, 2024 at 6:16 AM wrote: > > > > > So, will it be okay if we just remove ".. without losing data" from > > > > the sentence? Will that avoid the confusion you have? > > > Yes. Additionally, it would be better to add notes about data > > > consistency after failover for example > > >

RE: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-27 Thread Masahiro.Ikeda
> > > So, will it be okay if we just remove ".. without losing data" from > > > the sentence? Will that avoid the confusion you have? > > Yes. Additionally, it would be better to add notes about data > > consistency after failover for example > > > > Note that data consistency after failover can va

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-27 Thread Amit Kapila
On Tue, Aug 27, 2024 at 3:05 PM wrote: > > > So, will it be okay if we just remove ".. without losing data" from the > > sentence? Will that > > avoid the confusion you have? > Yes. Additionally, it would be better to add notes about data consistency > after failover for example > > Note that da

RE: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-27 Thread Masahiro.Ikeda
> So, will it be okay if we just remove ".. without losing data" from the > sentence? Will that > avoid the confusion you have? Yes. Additionally, it would be better to add notes about data consistency after failover for example Note that data consistency after failover can vary depending on the

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-27 Thread Amit Kapila
On Tue, Aug 27, 2024 at 10:18 AM wrote: > > > I think you see such a behavior because you have disabled > > 'synchronized_standby_slots' > > in your script (# disable "synchronized_standby_slots"). You need to enable > > that to > > avoid data loss. Considering that, I don't think your proposed

RE: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread Masahiro.Ikeda
Thans for your responses. > I think you see such a behavior because you have disabled > 'synchronized_standby_slots' > in your script (# disable "synchronized_standby_slots"). You need to enable > that to > avoid data loss. Considering that, I don't think your proposed text is an > improvement.

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread David G. Johnston
On Monday, August 26, 2024, Amit Kapila wrote: > On Mon, Aug 26, 2024 at 6:38 PM Zhijie Hou (Fujitsu) > wrote: > > > > On Monday, August 26, 2024 5:37 PM Amit Kapila > wrote: > > > > > > On Mon, Aug 26, 2024 at 1:30 PM wrote: > > > > > > > > When I read the following documentation related to t

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread Amit Kapila
On Mon, Aug 26, 2024 at 6:38 PM Zhijie Hou (Fujitsu) wrote: > > On Monday, August 26, 2024 5:37 PM Amit Kapila > wrote: > > > > On Mon, Aug 26, 2024 at 1:30 PM wrote: > > > > > > When I read the following documentation related to the > > "synchronized_standby_slots", I misunderstood that data l

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread Amit Kapila
On Mon, Aug 26, 2024 at 1:30 PM wrote: > > When I read the following documentation related to the > "synchronized_standby_slots", I misunderstood that data loss would not occur > in the case of synchronous physical replication. However, this is incorrect > (see reproduce.txt). > I think you se

RE: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread Zhijie Hou (Fujitsu)
On Monday, August 26, 2024 5:37 PM Amit Kapila wrote: > > On Mon, Aug 26, 2024 at 1:30 PM wrote: > > > > When I read the following documentation related to the > "synchronized_standby_slots", I misunderstood that data loss would not occur > in the case of synchronous physical replication. Howeve

Re: Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread Amit Kapila
On Mon, Aug 26, 2024 at 1:30 PM wrote: > > When I read the following documentation related to the > "synchronized_standby_slots", I misunderstood that data loss would not occur > in the case of synchronous physical replication. However, this is incorrect > (see reproduce.txt). > > > Note that i

Doc: fix the note related to the GUC "synchronized_standby_slots"

2024-08-26 Thread Masahiro.Ikeda
Hi, When I read the following documentation related to the "synchronized_standby_slots", I misunderstood that data loss would not occur in the case of synchronous physical replication. However, this is incorrect (see reproduce.txt). > Note that in the case of asynchronous replication, there re