Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-30 Thread Daniel Bauman
On Tue, Jul 29, 2025 at 11:46 AM David G. Johnston < david.g.johns...@gmail.com> wrote: > > > On Tue, Jul 29, 2025, 10:07 Daniel Bauman wrote: > >> >> The tradeoff to ignore errors and not fsync every log absolutely makes >> sense to me. It's just something it would be beneficial for users to be

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-29 Thread David G. Johnston
On Tue, Jul 29, 2025, 10:07 Daniel Bauman wrote: > > The tradeoff to ignore errors and not fsync every log absolutely makes > sense to me. It's just something it would be beneficial for users to be > aware of. Particularly those concerned with auditing. > The main question is where to put such i

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-29 Thread Daniel Bauman
On Tue, Jul 29, 2025 at 8:46 AM David G. Johnston < david.g.johns...@gmail.com> wrote: > On Monday, July 28, 2025, Daniel Bauman wrote: > >> The doc fragment you shared is explaining to customers that basic syntax >> checks are done before postgres gets to logging the transaction. >> I don't thin

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-29 Thread David G. Johnston
On Monday, July 28, 2025, Daniel Bauman wrote: > The doc fragment you shared is explaining to customers that basic syntax > checks are done before postgres gets to logging the transaction. > I don't think that is the same as clearly explaining to users statement > logging happens before execution

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-29 Thread Daniel Bauman
The doc fragment you shared is explaining to customers that basic syntax checks are done before postgres gets to logging the transaction. I don't think that is the same as clearly explaining to users statement logging happens before execution. At least for me, as a user and reader of the docs but n

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-29 Thread Daniel Bauman
Here's where I think the logging is happening. https://github.com/postgres/postgres/blob/master/src/backend/tcop/postgres.c#L1070 It seems like the log is happening before application of the transaction, not after. So consistency is best effort. ie - a crash after the log but before the transactio

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-29 Thread Bruce Momjian
On Mon, Jul 28, 2025 at 07:35:51PM -0400, Bruce Momjian wrote: > On Mon, Jul 28, 2025 at 04:24:14PM -0700, Daniel Bauman wrote: > > Here's where I think the logging is happening. https://github.com/postgres/ > > postgres/blob/master/src/backend/tcop/postgres.c#L1070 > > It seems like the log is hap

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-28 Thread David G. Johnston
On Monday, July 28, 2025, Bruce Momjian wrote: > On Mon, Jul 28, 2025 at 04:24:14PM -0700, Daniel Bauman wrote: > > Here's where I think the logging is happening. https://github.com/ > postgres/ > > postgres/blob/master/src/backend/tcop/postgres.c#L1070 > > It seems like the log is happening befo

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-28 Thread Bruce Momjian
On Mon, Jul 28, 2025 at 04:24:14PM -0700, Daniel Bauman wrote: > Here's where I think the logging is happening. https://github.com/postgres/ > postgres/blob/master/src/backend/tcop/postgres.c#L1070 > It seems like the log is happening before application of the transaction, not > after. > > So cons

Re: Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-28 Thread Bruce Momjian
On Fri, Jul 25, 2025 at 03:24:48PM -0700, Daniel Bauman wrote: > Hey pgsql hackers > This is my first email to this list. I'm reaching out about a possible doc > update for the log_statement parameter. > Here's the current doc - https://www.postgresql.org/docs/current/ > runtime-config-logging.html

Doc update proposal for the note on log_statement in the runtime config for logging page

2025-07-26 Thread Daniel Bauman
Hey pgsql hackers This is my first email to this list. I'm reaching out about a possible doc update for the log_statement parameter. Here's the current doc - https://www.postgresql.org/docs/current/runtime-config-logging.html The doc already has a Note bubble for the log_statement parameter with so