Re: Drop --disable-floatN-byval configure options?

2018-02-22 Thread Peter Eisentraut
On 2/21/18 12:17, Tom Lane wrote: > I don't actually envision changing the C code much at all; we might want > to resurrect the old code at some point. I just want to reduce the number > of supported configurations. Yeah, it can exist like EXEC_BACKEND, as a way to manually simulate a different

Re: Drop --disable-floatN-byval configure options?

2018-02-21 Thread Tom Lane
Robert Haas writes: > On Wed, Feb 21, 2018 at 10:50 AM, Tom Lane wrote: >> I have a modest >> substitute proposal: let's just drop the --disable-float4-byval and >> --disable-float8-byval configure options as of v11. Those don't have any >> impact on

Re: Drop --disable-floatN-byval configure options?

2018-02-21 Thread Robert Haas
On Wed, Feb 21, 2018 at 10:50 AM, Tom Lane wrote: > Per the discussion at > https://www.postgresql.org/message-id/flat/54dfd2022c205eda9aa35b88923f027a%40postgrespro.ru > it's become evident that use of --disable-float8-byval breaks at least one > current regression test case,

Drop --disable-floatN-byval configure options?

2018-02-21 Thread Tom Lane
Per the discussion at https://www.postgresql.org/message-id/flat/54dfd2022c205eda9aa35b88923f027a%40postgrespro.ru it's become evident that use of --disable-float8-byval breaks at least one current regression test case, because it results in a large change in hash table size for float8 hash keys.