Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2024-04-07 Thread Tom Lane
"Daniel Verite" writes: > Also the use of "and/or" in the previous version conveys the fact > that operator class and ordering options are not mutually > exclusive. But when using "any of the following" in the new text, > doesn't it loose that meaning? Yeah; and/or is perfectly fine here and does

Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-12-01 Thread Daniel Verite
shihao zhong wrote: > Thanks for your comments, a new version is attached. In this hunk: @@ -1097,8 +1097,8 @@ WITH ( MODULUS numeric_literal, REM method index_method. The operators are required to be commutative. Each exclude_element - can optionally specify an

Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-11-28 Thread Shubham Khanna
On Fri, Nov 17, 2023 at 4:55 AM shihao zhong wrote: > > Hi Jian, > > Thanks for your comments, a new version is attached. > > Thanks, > Shihao > > On Fri, Nov 10, 2023 at 9:59 AM jian he wrote: >> >> On Wed, Nov 1, 2023 at 10:30 AM shihao zhong wrote: >> > >> > Thank you for your feedback on my

Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-11-16 Thread shihao zhong
Hi Jian, Thanks for your comments, a new version is attached. Thanks, Shihao On Fri, Nov 10, 2023 at 9:59 AM jian he wrote: > On Wed, Nov 1, 2023 at 10:30 AM shihao zhong > wrote: > > > > Thank you for your feedback on my previous patch. I have fixed the issue > and attached a new patch for y

Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-11-10 Thread jian he
On Wed, Nov 1, 2023 at 10:30 AM shihao zhong wrote: > > Thank you for your feedback on my previous patch. I have fixed the issue and > attached a new patch for your review. Could you please take a look for it if > you have a sec? Thanks > Your patch works fine. you can see it here: https://cirr

Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-10-31 Thread shihao zhong
On Tue, Oct 31, 2023 at 9:07 PM Tom Lane wrote: > shihao zhong writes: > > I noticed that the CREATE/ALTER TABLE document does not mention that > > EXCLUDE can accept a collation. I created a documentation fix for this > > issue, and I have attached it to this email. > > > Hmm ... is this actual

Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-10-31 Thread Tom Lane
shihao zhong writes: > I noticed that the CREATE/ALTER TABLE document does not mention that > EXCLUDE can accept a collation. I created a documentation fix for this > issue, and I have attached it to this email. Hmm ... is this actually correct? I think that the collate option has to come before

EXCLUDE COLLATE in CREATE/ALTER TABLE document

2023-10-31 Thread shihao zhong
Hi hackers, I hope this email finds you well. I noticed that the CREATE/ALTER TABLE document does not mention that EXCLUDE can accept a collation. I created a documentation fix for this issue, and I have attached it to this email. Please let me know if you have any questions or concerns. Thanks