Re: Erroneous -Werror=missing-braces on old GCC

2023-12-24 Thread Tom Lane
I wrote: > Richard Guo writes: >> I came across the 'missing braces' warning again when building master >> (0a93f803f4) on old GCC (4.8.5). > On the one hand, it's probably pointless to worry about buggy > warnings from ancient compilers ... Actually, after checking the buildfarm, I see that

Re: Erroneous -Werror=missing-braces on old GCC

2023-12-24 Thread Tom Lane
Richard Guo writes: > I came across the 'missing braces' warning again when building master > (0a93f803f4) on old GCC (4.8.5). On the one hand, it's probably pointless to worry about buggy warnings from ancient compilers ... > This has popped up a few times in the past, and it seems to be GCC

Re: Erroneous -Werror=missing-braces on old GCC

2023-12-24 Thread Japin Li
On Mon, 25 Dec 2023 at 10:42, Richard Guo wrote: > I came across the 'missing braces' warning again when building master > (0a93f803f4) on old GCC (4.8.5). > > blkreftable.c: In function ‘BlockRefTableSetLimitBlock’: > blkreftable.c:268:2: warning: missing braces around initializer >

Erroneous -Werror=missing-braces on old GCC

2023-12-24 Thread Richard Guo
I came across the 'missing braces' warning again when building master (0a93f803f4) on old GCC (4.8.5). blkreftable.c: In function ‘BlockRefTableSetLimitBlock’: blkreftable.c:268:2: warning: missing braces around initializer [-Wmissing-braces] BlockRefTableKey key = {0}; /* make sure any padding