Re: Extend compatibility of PostgreSQL::Test::Cluster

2022-03-30 Thread Andrew Dunstan
On 3/30/22 01:55, Michael Paquier wrote: > On Tue, Mar 29, 2022 at 05:56:02PM -0400, Andrew Dunstan wrote: >> I'm not sure why this item has been moved to the next CF without any >> discussion I could see on the mailing list. It was always my intention >> to commit it this time, and I propose to

Re: Extend compatibility of PostgreSQL::Test::Cluster

2022-03-29 Thread Michael Paquier
On Tue, Mar 29, 2022 at 05:56:02PM -0400, Andrew Dunstan wrote: > I'm not sure why this item has been moved to the next CF without any > discussion I could see on the mailing list. It was always my intention > to commit it this time, and I propose to do so tomorrow with the comment > Michael has re

Re: Extend compatibility of PostgreSQL::Test::Cluster

2022-03-29 Thread Andrew Dunstan
On 1/21/22 09:59, Andrew Dunstan wrote: > On 1/21/22 02:47, Michael Paquier wrote: >> On Tue, Jan 18, 2022 at 06:35:39PM -0500, Andrew Dunstan wrote: >>> Here's a version that does that and removes some recent bitrot. >> I have been looking at the full set of features of Cluster.pm and the >> req

Re: Extend compatibility of PostgreSQL::Test::Cluster

2022-01-21 Thread Andrew Dunstan
On 1/21/22 02:47, Michael Paquier wrote: > On Tue, Jan 18, 2022 at 06:35:39PM -0500, Andrew Dunstan wrote: >> Here's a version that does that and removes some recent bitrot. > I have been looking at the full set of features of Cluster.pm and the > requirements behind v10 as minimal version suppor

Re: Extend compatibility of PostgreSQL::Test::Cluster

2022-01-20 Thread Michael Paquier
On Tue, Jan 18, 2022 at 06:35:39PM -0500, Andrew Dunstan wrote: > Here's a version that does that and removes some recent bitrot. I have been looking at the full set of features of Cluster.pm and the requirements behind v10 as minimal version supported, and nothing really stands out. + # old ve

Re: Extend compatibility of PostgreSQL::Test::Cluster

2022-01-18 Thread Andrew Dunstan
On 12/31/21 11:22, Andrew Dunstan wrote: > On 12/31/21 11:20, Dagfinn Ilmari Mannsåker wrote: >> Andrew Dunstan writes: >> >>> + my $subclass = __PACKAGE__ . "::V_$maj"; >>> + bless $node, $subclass; >>> + unless ($node->isa(__PACKAGE__)) >>> + { >>> +

Re: Extend compatibility of PostgreSQL::Test::Cluster

2021-12-31 Thread Andrew Dunstan
On 12/31/21 11:20, Dagfinn Ilmari Mannsåker wrote: > Andrew Dunstan writes: > >> +my $subclass = __PACKAGE__ . "::V_$maj"; >> +bless $node, $subclass; >> +unless ($node->isa(__PACKAGE__)) >> +{ >> +# It's not a subclass, so re-b

Re: Extend compatibility of PostgreSQL::Test::Cluster

2021-12-31 Thread Dagfinn Ilmari Mannsåker
Andrew Dunstan writes: > + my $subclass = __PACKAGE__ . "::V_$maj"; > + bless $node, $subclass; > + unless ($node->isa(__PACKAGE__)) > + { > + # It's not a subclass, so re-bless back into the main > package > +

Re: Extend compatibility of PostgreSQL::Test::Cluster

2021-12-28 Thread Andrew Dunstan
On 12/28/21 09:30, Andrew Dunstan wrote: > PFA a patch to extend the compatibility of PostgreSQL::Test::Cluster to > all live branches. It does this by introducing a couple of subclasses > which override a few things. The required class is automatically > detected and used, so users don't need to

Extend compatibility of PostgreSQL::Test::Cluster

2021-12-28 Thread Andrew Dunstan
PFA a patch to extend the compatibility of PostgreSQL::Test::Cluster to all live branches. It does this by introducing a couple of subclasses which override a few things. The required class is automatically detected and used, so users don't need to specify a subclass. Although this is my work it d