Re: Extend pgbench partitioning to pgbench_history

2024-05-14 Thread Robert Haas
On Fri, Feb 16, 2024 at 3:14 PM Melanie Plageman wrote: > [ review comments ] Since there has been no response to these review comments for more than 3 months, I have set https://commitfest.postgresql.org/48/4679/ to Returned with Feedback. Please feel free to update the status when there is a

Re: Extend pgbench partitioning to pgbench_history

2024-02-16 Thread Melanie Plageman
On Fri, Feb 16, 2024 at 12:50 PM Tomas Vondra wrote: > > Hello Gabriele, > > I think the improvement makes sense (it's indeed a bit strange to not > partition the history table), and the patch looks good. > > I did think about whether this should be optional in some way - that is, > separate from

Re: Extend pgbench partitioning to pgbench_history

2024-02-16 Thread Tomas Vondra
Hello Gabriele, I think the improvement makes sense (it's indeed a bit strange to not partition the history table), and the patch looks good. I did think about whether this should be optional in some way - that is, separate from partitioning the accounts table, and users would have to explicitly

Re: Extend pgbench partitioning to pgbench_history

2024-01-30 Thread Gabriele Bartolini
Hi Abhijit, Thanks for your input. Please accept my updated patch. Ciao, Gabriele On Tue, 16 Jan 2024 at 12:53, Abhijit Menon-Sen wrote: > At 2023-11-30 11:29:15 +0100, gabriele.bartol...@enterprisedb.com wrote: > > > > With the attached patch, I extend the partitioning capability to the > >

Re: Extend pgbench partitioning to pgbench_history

2024-01-16 Thread Abhijit Menon-Sen
At 2023-11-30 11:29:15 +0100, gabriele.bartol...@enterprisedb.com wrote: > > With the attached patch, I extend the partitioning capability to the > pgbench_history table too. > > I have been thinking of adding an option to control this, but I preferred > to ask in this list whether it really

Re: Extend pgbench partitioning to pgbench_history

2024-01-10 Thread Shlok Kyal
Sorry, I did not intend to send this message for this email. I by mistake sent this mail. Please ignore this mail On Wed, 10 Jan 2024 at 15:27, Shlok Kyal wrote: > > Hi, > > There are some test failures reported by Cfbot at [1]: > > [09:15:01.794] 192/276 postgresql:pgbench / >

Re: Extend pgbench partitioning to pgbench_history

2024-01-10 Thread Shlok Kyal
Hi, There are some test failures reported by Cfbot at [1]: [09:15:01.794] 192/276 postgresql:pgbench / pgbench/001_pgbench_with_server ERROR 7.48s exit status 3 [09:15:01.794] >>> INITDB_TEMPLATE=/tmp/cirrus-ci-build/build/tmp_install/initdb-template

Re: Extend pgbench partitioning to pgbench_history

2023-11-30 Thread Gabriele Bartolini
Please discard the previous patch and use this one (it had a leftover comment from an initial attempt to limit this to hash case). Thanks, Gabriele On Thu, 30 Nov 2023 at 11:29, Gabriele Bartolini < gabriele.bartol...@enterprisedb.com> wrote: > Hi there, > > While benchmarking a new feature

Extend pgbench partitioning to pgbench_history

2023-11-30 Thread Gabriele Bartolini
Hi there, While benchmarking a new feature involving tablespace support in CloudNativePG (Kubernetes operator), I wanted to try out the partitioning feature of pgbench. I saw it supporting both range and hash partitioning, but limited to pgbench_accounts. With the attached patch, I extend the