Re: FOR EACH ROW triggers, on partitioend tables, with indexes?

2022-09-05 Thread David Rowley
On Thu, 1 Sept 2022 at 20:57, Alvaro Herrera wrote: > So apparently the way to get a trigger associated with a relation > (tgconstrrelid) is via CREATE CONSTRAINT TRIGGER, but there doesn't > appear to be a way to have it associated with a specific *index* on that > relation (tgconstrindid). So y

Re: FOR EACH ROW triggers, on partitioend tables, with indexes?

2022-09-01 Thread Alvaro Herrera
On 2022-Aug-19, Justin Pryzby wrote: > That would be a memory leak or some other bug, except that it also seems to be > dead code ? > > https://coverage.postgresql.org/src/backend/commands/trigger.c.gcov.html#1166 > > Is it somwhow possible to call CreateTrigger() to create a FOR EACH ROW > trig

Re: FOR EACH ROW triggers, on partitioend tables, with indexes?

2022-08-31 Thread Justin Pryzby
On Thu, Sep 01, 2022 at 04:19:37PM +1200, David Rowley wrote: > On Sat, 20 Aug 2022 at 09:18, Justin Pryzby wrote: > > Is it somwhow possible to call CreateTrigger() to create a FOR EACH ROW > > trigger, with an index, and not internally ? > > I've been looking over this and I very much agree tha

Re: FOR EACH ROW triggers, on partitioend tables, with indexes?

2022-08-31 Thread David Rowley
On Sat, 20 Aug 2022 at 09:18, Justin Pryzby wrote: > Is it somwhow possible to call CreateTrigger() to create a FOR EACH ROW > trigger, with an index, and not internally ? I've been looking over this and I very much agree that the code looks very broken. As for whether this is dead code or not, I

FOR EACH ROW triggers, on partitioend tables, with indexes?

2022-08-19 Thread Justin Pryzby
On Wed, Aug 17, 2022 at 09:54:34AM -0500, Justin Pryzby wrote: > But an unfortunate consequence of not fixing the historic issues is that it > precludes the possibility that anyone could be expected to notice if they > introduce more instances of the same problem (as in the first half of these > pa